Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

api: Add transport_api_version to SelfConfigSource. #11754

Merged

Conversation

markdroth
Copy link
Contributor

Signed-off-by: Mark D. Roth [email protected]

Commit Message: api: Add transport_api_version to SelfConfigSource.
Additional Description: This will allow configuring the version of LRS independently from the version of xDS in the lrs_server field in Cluster messages.
Risk Level: Low
Testing: N/A
Docs Changes: Inline in PR
Release Notes: N/A

@repokitteh-read-only
Copy link

CC @envoyproxy/api-shepherds: Your approval is needed for changes made to api/envoy/.
CC @envoyproxy/api-watchers: FYI only for changes made to api/envoy/.

🐱

Caused by: #11754 was opened by markdroth.

see: more, trace.

@markdroth
Copy link
Contributor Author

As discussed with @htuch.

@htuch htuch merged commit edaad6d into envoyproxy:master Jun 25, 2020
@markdroth markdroth deleted the self_config_source_transport_api_version branch June 26, 2020 19:11
yashwant121 pushed a commit to yashwant121/envoy that referenced this pull request Jul 24, 2020
This will allow configuring the version of LRS independently from the version of xDS in the lrs_server field in Cluster messages.

Risk Level: Low
Testing: N/A
Docs Changes: Inline in PR

Signed-off-by: Mark D. Roth <[email protected]>
Signed-off-by: yashwant121 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants