-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[test] Transition some benchmarks over to take advantage of envoy_cc_benchmark_binary and envoy_benchmark_test #10409
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -49,7 +49,7 @@ class CommandSplitSpeedTest { | |
void createShared(Common::Redis::RespValueSharedPtr request) { | ||
for (uint64_t i = 1; i < request->asArray().size(); i += 2) { | ||
auto single_set = std::make_shared<const Common::Redis::RespValue>( | ||
request, Common::Redis::Utility::SetRequest::instance(), i, i + 2); | ||
request, Common::Redis::Utility::SetRequest::instance(), i, i + 1); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Why this change? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. See #9541 [2020-03-17 02:43:10.078][15][critical][assert] [bazel-out/k8-fastbuild/bin/source/extensions/filters/network/common/redis/virtual_includes/codec_interface/extensions/filters/network/common/redis/codec.h:67] assert failure: end < base_array->asArray().size(). ERROR: AddressSanitizer: ABRT on unknown address 0x14e380000000f (pc 0x7f840d1d0081 bp 0x7ffe76012050 sp 0x7ffe76011910 T0) AddressSanitizer can not provide additional info. |
||
} | ||
} | ||
|
||
|
@@ -130,13 +130,3 @@ static void BM_Split_CreateVariant(benchmark::State& state) { | |
state.counters["use_count"] = request.use_count(); | ||
} | ||
BENCHMARK(BM_Split_CreateVariant)->Ranges({{1, 100}, {64, 8 << 14}}); | ||
|
||
// Boilerplate main(), which discovers benchmarks in the same file and runs them. | ||
int main(int argc, char** argv) { | ||
benchmark::Initialize(&argc, argv); | ||
|
||
if (benchmark::ReportUnrecognizedArguments(argc, argv)) { | ||
return 1; | ||
} | ||
benchmark::RunSpecifiedBenchmarks(); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this being changed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See #9540
size_t is an unsigned type. -2 ends up being interpreted as 9223372036854775806UL
interval set requires insert arguments to be sorted in value, so interval_set.insert(-2, 23), also known as interval_set.insert(9223372036854775806UL, 23) triggers an ASSERT failure in debug modes.