Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

envoy_restart_features_explicit_wildcard_resource #29166

Closed
alyssawilk opened this issue Aug 21, 2023 · 0 comments · Fixed by #29339
Closed

envoy_restart_features_explicit_wildcard_resource #29166

alyssawilk opened this issue Aug 21, 2023 · 0 comments · Fixed by #29339
Assignees
@alyssawilk
Labels
enhancement Feature requests. Not bugs or questions. no stalebot Disables stalebot from closing an issue

Comments

@alyssawilk
Copy link
Contributor

Your change #16855 (Add support for explicit wildcard resource) introduced a runtime guarded feature. It has been 6 months since the new code has been exercised by default, so it's time to remove the old code path. This issue tracks source code cleanup so we don't forget.
cc @krnowak
@alyssawilk alyssawilk added enhancement Feature requests. Not bugs or questions. no stalebot Disables stalebot from closing an issue labels Aug 21, 2023
@alyssawilk alyssawilk self-assigned this Aug 30, 2023
@alyssawilk alyssawilk mentioned this issue Aug 30, 2023
Merged
htuch pushed a commit that referenced this issue Sep 5, 2023
@alyssawilk
runtime: removing envoy.restart_features.explicit_wildcard_resource (#…
212b66a 
…29339)

Risk Level: low
Testing: n/a
Docs Changes: n/a
Release Notes: inline
Fixes #29166

Signed-off-by: Alyssa Wilk <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alyssawilk alyssawilk

Labels
enhancement Feature requests. Not bugs or questions. no stalebot Disables stalebot from closing an issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

runtime: removing envoy.restart_features.explicit_wildcard_resource alyssawilk/envoy
1 participant
@alyssawilk