-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
quic: support in-place filterChainUpdate #13115
Comments
lazy-ask: was this not accepting updates to the quic filter chain, or not being able to in-place add/remove quic listeners? |
The call to |
OK, I think we need to either support this for alpha or make it really clear in docs it's not yet supported. It shouldn't be too much work to forward packets for old connections to the old listener and new to the new listener, but it's not trivial. |
The ownership of the filter chain is not clear to me: Quic listener need to decide whether the old and new config has filter chain only change. |
Ok, I'm going to note lack of support in the docs PR, so removing this from the Alpha list. |
Commit Message: updateListenerConfig() and onFilterChainDraining() to ActiveListener interface and implement them in ActiveQuicListener. Unblock listener update for UDP listener. Risk Level: high, touches LDS. Testing: new integration tests Fixes #13115 Signed-off-by: Dan Zhang <[email protected]>
Need to add handling in udp case here:
envoy/source/server/connection_handler_impl.cc
Line 40 in 4706ee0
The text was updated successfully, but these errors were encountered: