Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature request: Histogram for header sizes #10308

Closed
nezdolik opened this issue Mar 9, 2020 · 12 comments · Fixed by #11559
Closed

Feature request: Histogram for header sizes #10308

nezdolik opened this issue Mar 9, 2020 · 12 comments · Fixed by #11559
Assignees
@nezdolik
Labels
area/http area/stats no stalebot Disables stalebot from closing an issue

Comments

@nezdolik
Copy link
Member

nezdolik commented Mar 9, 2020

Would be nice to enrich existing stats with histogram for header sizes per upstream.
Can work on this feature if it's something we want to add.
@mattklein123
Copy link
Member

cc @jmarantz @adisuissa this might be useful for header map optimization work?

@stale
Copy link

stale bot commented Apr 8, 2020

This issue has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in the next 7 days unless it is tagged "help wanted" or other activity occurs. Thank you for your contributions.

@stale stale bot added the stale stalebot believes this issue/PR has not been touched recently label Apr 8, 2020
@stale
Copy link

stale bot commented Apr 17, 2020

This issue has been automatically closed because it has not had activity in the last 37 days. If this issue is still valid, please ping a maintainer and ask them to label it as "help wanted". Thank you for your contributions.

@stale stale bot closed this as completed Apr 17, 2020
@jmarantz jmarantz reopened this Apr 29, 2020
@stale stale bot removed the stale stalebot believes this issue/PR has not been touched recently label Apr 29, 2020
@jmarantz jmarantz added the no stalebot Disables stalebot from closing an issue label Apr 29, 2020
@jmarantz
Copy link
Contributor

Assigning to @nezdolik for now, possibly to be re-assigned later.

@sresthas
Copy link

Hi, I would love to work on this. @nezdolik can you please tell me how to get started. Thanks :-)

@nezdolik
Copy link
Member Author

nezdolik commented Apr 30, 2020 •
edited
Loading

@sresthas this issue has been submitted as proposal for cncf mentorship project: https://github.com/cncf/mentoring/blob/master/communitybridge/2020/q2/project_ideas.md#enrich-envoy-stats-with-header-size-histogram.
How about this issue, is very similar: #3621. Let me know if i could help.

@Dhiraj240
Copy link

@nezdolik I would like to work on it during the mentorship. Can you assign me a similar issue?

Also, may I know the common chat channel to discuss more?

@Dhiraj240
Copy link

@nezdolik Any updates, I have been waiting on how to get started and discuss with you.

@nezdolik
Copy link
Member Author

nezdolik commented May 4, 2020 •
edited
Loading

Hi @Dhiraj240 not sure i understand, here is schedule: https://github.com/cncf/mentoring/tree/master/communitybridge/2020/q2 and you need to apply as mentee.
I also have no power to assign issue, but you can just make sure the issue is not being worked on by someone else and post a comment like "Hello, i would like to help out with this issue".

@Dhiraj240
Copy link

@nezdolik For selection, is contribution necessary in envoy?

@nezdolik
Copy link
Member Author

nezdolik commented May 4, 2020

@Dhiraj240 is not required, for more questions you could reach out on slack not to spam issue thread.

@Dhiraj240
Copy link

@nezdolik I have applied on community bridge and messaged you on slack for more information. You can check my portfolio here at https://dhiraj240.github.io/

@ranjithkumar007 ranjithkumar007 mentioned this issue Jun 11, 2020
Merged
htuch pushed a commit that referenced this issue Jul 21, 2020
@ranjithkumar007
stats: add histograms for request/response headers and body sizes (#1…
a24c95e 
…1559)

Created a new struct for optional cluster stats. Moved timeout budget stats and added request response headers and body stats in the new struct.

Risk Level: Low
Testing: Added test cases
Docs Changes: added
Release Notes: added

Fixes #10308 , Fixes #3621

Signed-off-by: Ranjith Kumar <[email protected]>
KBaichoo pushed a commit to KBaichoo/envoy that referenced this issue Jul 30, 2020
@ranjithkumar007 @KBaichoo
stats: add histograms for request/response headers and body sizes (en…
93c977e 
…voyproxy#11559)

Created a new struct for optional cluster stats. Moved timeout budget stats and added request response headers and body stats in the new struct.

Risk Level: Low
Testing: Added test cases
Docs Changes: added
Release Notes: added

Fixes envoyproxy#10308 , Fixes envoyproxy#3621

Signed-off-by: Ranjith Kumar <[email protected]>
Signed-off-by: Kevin Baichoo <[email protected]>
scheler pushed a commit to scheler/envoy that referenced this issue Aug 4, 2020
@ranjithkumar007
stats: add histograms for request/response headers and body sizes (en…
9ff7f61 
…voyproxy#11559)

Created a new struct for optional cluster stats. Moved timeout budget stats and added request response headers and body stats in the new struct.

Risk Level: Low
Testing: Added test cases
Docs Changes: added
Release Notes: added

Fixes envoyproxy#10308 , Fixes envoyproxy#3621

Signed-off-by: Ranjith Kumar <[email protected]>
Signed-off-by: scheler <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nezdolik nezdolik

Labels
area/http area/stats no stalebot Disables stalebot from closing an issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

stats: add histograms for request/response headers and body sizes ranjithkumar007/envoy
5 participants
@jmarantz @mattklein123 @nezdolik @Dhiraj240 @sresthas