Skip to content

Commit

Permalink
opentracing: remove legacy open tracing extension
Browse files Browse the repository at this point in the history
Signed-off-by: Alyssa Wilk <[email protected]>
  • Loading branch information
alyssawilk committed Jul 24, 2024
1 parent 581bfe6 commit 01300b3
Show file tree
Hide file tree
Showing 15 changed files with 4 additions and 644 deletions.
159 changes: 0 additions & 159 deletions bazel/io_opentracing_cpp.patch

This file was deleted.

14 changes: 0 additions & 14 deletions bazel/repositories.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@ WINDOWS_SKIP_TARGETS = [
"envoy.filters.http.file_system_buffer",
"envoy.filters.http.language",
"envoy.filters.http.sxg",
"envoy.tracers.dynamic_ot",
"envoy.tracers.datadog",
"envoy.tracers.opencensus",
# Extensions that require CEL.
Expand Down Expand Up @@ -338,7 +337,6 @@ def envoy_dependencies(skip_targets = []):
_com_googlesource_googleurl()
_io_hyperscan()
_io_vectorscan()
_io_opentracing_cpp()
_io_opentelemetry_api_cpp()
_net_colm_open_source_colm()
_net_colm_open_source_ragel()
Expand Down Expand Up @@ -761,18 +759,6 @@ def _io_vectorscan():
patches = ["@envoy//bazel/foreign_cc:vectorscan.patch"],
)

def _io_opentracing_cpp():
external_http_archive(
name = "io_opentracing_cpp",
patch_args = ["-p1"],
# Workaround for LSAN false positive in https://github.com/envoyproxy/envoy/issues/7647
patches = ["@envoy//bazel:io_opentracing_cpp.patch"],
)
native.bind(
name = "opentracing",
actual = "@io_opentracing_cpp//:opentracing",
)

def _io_opentelemetry_api_cpp():
external_http_archive(name = "io_opentelemetry_cpp")
native.bind(
Expand Down
18 changes: 0 additions & 18 deletions bazel/repository_locations.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -550,24 +550,6 @@ REPOSITORY_LOCATIONS_SPEC = dict(
license = "BSD-3-Clause",
license_url = "https://github.com/VectorCamp/vectorscan/blob/vectorscan/{version}/LICENSE",
),
io_opentracing_cpp = dict(
project_name = "OpenTracing",
project_desc = "Vendor-neutral APIs and instrumentation for distributed tracing",
project_url = "https://opentracing.io",
version = "1.5.1",
sha256 = "015c4187f7a6426a2b5196f0ccd982aa87f010cf61f507ae3ce5c90523f92301",
strip_prefix = "opentracing-cpp-{version}",
urls = ["https://github.com/opentracing/opentracing-cpp/archive/v{version}.tar.gz"],
use_category = ["observability_ext"],
extensions = [
"envoy.tracers.datadog",
"envoy.tracers.dynamic_ot",
],
release_date = "2019-01-16",
cpe = "N/A",
license = "Apache-2.0",
license_url = "https://github.com/opentracing/opentracing-cpp/blob/v{version}/LICENSE",
),
io_opentelemetry_cpp = dict(
project_name = "OpenTelemetry",
project_desc = "Observability framework and toolkit designed to create and manage telemetry data such as traces, metrics, and logs.",
Expand Down
4 changes: 4 additions & 0 deletions changelogs/current.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,10 @@ date: Pending

behavior_changes:
# *Changes that are expected to cause an incompatibility if applicable; deployment changes are likely required*
- area: tracing
change: |
Removed support for (long deprecated) opentracing. See `issue 27401
<https://github.com/envoyproxy/envoy/issues/27401>`_ for details.
minor_behavior_changes:
# *Changes that may cause incompatibilities for some users, but should not for most*
Expand Down
1 change: 0 additions & 1 deletion source/extensions/extensions_build_config.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -267,7 +267,6 @@ EXTENSIONS = {
# Tracers
#

"envoy.tracers.dynamic_ot": "//source/extensions/tracers/dynamic_ot:config",
"envoy.tracers.datadog": "//source/extensions/tracers/datadog:config",
"envoy.tracers.zipkin": "//source/extensions/tracers/zipkin:config",
"envoy.tracers.opencensus": "//source/extensions/tracers/opencensus:config",
Expand Down
7 changes: 0 additions & 7 deletions source/extensions/extensions_metadata.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -1201,13 +1201,6 @@ envoy.tracers.datadog:
status: stable
type_urls:
- envoy.config.trace.v3.DatadogConfig
envoy.tracers.dynamic_ot:
categories:
- envoy.tracers
security_posture: unknown
status: stable
type_urls:
- envoy.config.trace.v3.DynamicOtConfig
envoy.tracers.opencensus:
categories:
- envoy.tracers
Expand Down
37 changes: 0 additions & 37 deletions source/extensions/tracers/dynamic_ot/BUILD

This file was deleted.

39 changes: 0 additions & 39 deletions source/extensions/tracers/dynamic_ot/config.cc

This file was deleted.

31 changes: 0 additions & 31 deletions source/extensions/tracers/dynamic_ot/config.h

This file was deleted.

Loading

0 comments on commit 01300b3

Please sign in to comment.