This repository has been archived by the owner on Dec 16, 2020. It is now read-only.
wasm: use values extracted from Emscripten metadata. #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows us to use more recent versions of Emscripten. Signed-off-by: Piotr Sikora <[email protected]>
Signed-off-by: Piotr Sikora <[email protected]>
Signed-off-by: Piotr Sikora <[email protected]>
Signed-off-by: Piotr Sikora <[email protected]>
jplevyak
reviewed
Jun 4, 2019
| if (is_emscripten_) { | ||
| if (emscripten_abi_major_version_ > 0 || emscripten_abi_minor_version_ > 1) { |
There was a problem hiding this comment.
Do you want to check the precise version and then fail to load the module if it isn't one of the know versions?
There was a problem hiding this comment.
I don't, because then we'd stop loading working WASM modules (e.g. neither change to ABI 0.1 nor 0.3 required any changes in Envoy-WASM)... unless you feel strongly about it?
jplevyak
approved these changes
Jun 4, 2019
yxue
pushed a commit
to yxue/envoy-wasm
that referenced
this pull request
Oct 8, 2019
…roxy#29) * Add Exception handling and test for divide by zero exception.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows us to use more recent versions of Emscripten.
Fixes #32.
Signed-off-by: Piotr Sikora [email protected]