Tooltips in env_cell.js, actions-overlay, edit, copy, remove

[allen-munsch]

I was scared to press any of the hoverable actions-overlay, because I had no idea what they did. Would it be possible to add a tooltip for these?

I was glad this is an electron application, as I was able to track down what I was looking at.

envkey-app/envkey-react/src/components/env_manager/env_cell/env_cell.js

_renderActions(){
    return h.div(".actions-overlay", this._actions().map(::this._renderAction))
  }

Rendered html:

<div class="actions-overlay">
    <span class="edit">
        <span class="img-bg-wrap"></span>
        <img src="assets/images/edit-circle-black.png">
    </span>
    <span class="copy">
        <span class="img-bg-wrap"></span>
        <img src="assets/images/copy-circle-black.png">
    </span>
    <span class="remove">
        <span class="img-bg-wrap"></span>
        <img src="assets/images/remove-circle-black.png">
    </span>
</div>

[danenania]

Good idea! Will definitely get it into the next release.

…

On Mon, Nov 5, 2018 at 12:19 PM enderplux ***@***.***> wrote: I was scared to press any of the hoverable actions-overlay, because I had no idea what they did. Would it be possible to add a tooltip for these? envkey-app/envkey-react/src/components/env_manager/env_cell/env_cell.js _renderActions(){ return h.div(".actions-overlay", this._actions().map(::this._renderAction)) } Rendered html: <div class="actions-overlay"> <span class="edit"> <span class="img-bg-wrap"></span> <img src="assets/images/edit-circle-black.png"> </span> <span class="copy"> <span class="img-bg-wrap"></span> <img src="assets/images/copy-circle-black.png"> </span> <span class="remove"> <span class="img-bg-wrap"></span> <img src="assets/images/remove-circle-black.png"> </span> </div> — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#18>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAhSRpbYttD6iYloeX_3WADgRfSKkaP7ks5usJ1ggaJpZM4YPMBP> .

[allen-munsch]

@danenania Thanks! That'd be awesome.

One other nit, that I didn't dig into, but not sure if the span elements could be ordered left to right

• copy, edit, remove

Although it might be more of "easier for a developer to read" type of change. It doesn't change the functionality at all.

[danenania]

@allen-munsch I think that was to get things laying out correctly in conjunction with css floats, but will take another look.