Updates supporting flux-recording at large number of locations along river corridor; other minor bug-fixes #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- we often have triangles at the stream confluence that have two edges on the river corridor. That does not impact results for most applications, however, can be critical for network connectivity studies. - this update provide a point at confluences that are likely to have such triangles; this point has to be honored during the triangulation.
…larity and performance
* function to create discharge regions
* minor improvements
* refinement based on polygons
* fix for nan-mean
* polygon-based refinement
* provided labeled sets for cells, just upstream of the discharge faces
these cells regions are to be provided as:
<Parameter name="direction normalized flux relative to region" type="string" value="discharge_cell_region_name" />
* cleanup
the preserve catchment option was provided in the prune functions but was not accessible in higher level functions like construct river.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Major Updates
Triangles with all three vertices on the stream mesh can cause issues for applications like stream network connectivity. They often can divert water from corridor through them and act like a braid. To deal with this a two-stage treatment is implemented, with user options to select the level of treatment. These options can be accessed through a optional flag
treat_stream_triangles : {'None', 'moderate', 'strict'}intessalate_river_alignedfunction:moderate: This will deploy refinement function of thetrianglelibrary, where stream triangles are identified and passed on for additional refinement. This can take of most of the triangles, however, it is not an strict enforcement as triangulation algorithm will try to balance between multiple constraints and refinement like angles and cell sizes.strict: This method will split the stream triangles that could not be refined with themoderateoption, by providing additional point (mid point of the off-river-corridor edge) during triangulation.See image below where a stream triangle was split; red markers depicts the original stream triangle.
Add labeled sets for three faces for each discharge point in the river corridor. The three faces include downstream shorter edge of the quad and two edges connecting two downstream vertices of the quad and non-quad vertice on the bank triangle. Corresponding upstreams cells (a quad and two triangles) are also added for
<Parameter name="direction normalized flux relative to region" type="string" value="discharge_cell_region_name" />in the ATS observation parameter list in the input fileReturns a graded refinement function based upon polygon area limits, for use with Triangle. Triangle area must be smaller than the area limit for the polygon when the triangle centroid is within the polygon
Minor updates:
construct_river