Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add build in setup command #136

Closed
wants to merge 1 commit into from
Closed

Conversation

malomarrec
Copy link

When using this repo for the first time and following README instructions, users won't have a build dist in the folder.
Running nm run setup will fail.
Adding npm run build in npm run setup makes it so you can "just follow the README instructions".

When using this repo for the first time and following README instructions, users won't have a build `dist` in the folder.
Running `nm run setup` will fail.
Adding `npm run build` in `npm run setup` makes it so you can "just follow the README instructions".
@enuchi
Copy link
Owner

enuchi commented Aug 10, 2022

Sure, let me take a look at this. Do you know why setup is failing if there's no dist folder?

@enuchi
Copy link
Owner

enuchi commented Aug 12, 2022

Looking more into this it looks like clasp was updated at some point and now tries to add the .clasp.json file and appscript.json manifest into the rootDir (./dist in this case).

Was able to find a relevant issue described here: google/clasp#869
Relevant code in PR that changed this behavior: https://github.com/google/clasp/pull/865/files#diff-b6d810b0306723c2b160e529addd463ae24be806303358ff1f6a2209bc13357dR108-R114

Thanks for flagging this. Need to think if running build first is the best solution though. May need to just reorganize files and update README.

@enuchi
Copy link
Owner

enuchi commented Aug 12, 2022

I'm going to create a new PR here: #137

This is somewhat of a workaround and less than ideal, but think it is the least disruptive to the project and allows users to just follow the README steps for setup. It should work now without a dist directory.

@enuchi enuchi mentioned this pull request Aug 12, 2022
@enuchi enuchi closed this Sep 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants