[mob] Reduce error severity (#2224)

## Description ## Tests
ente-io · Jun 19, 2024 · 477bc4c · 477bc4c
2 parents f78e01e + 9bf8e16
commit 477bc4c
Show file tree

Hide file tree

Showing 7 changed files with 17 additions and 13 deletions.
diff --git a/mobile/lib/core/error-reporting/super_logging.dart b/mobile/lib/core/error-reporting/super_logging.dart
@@ -5,6 +5,7 @@ import 'dart:collection';
 import 'dart:core';
 import 'dart:io';
 
+import "package:dio/dio.dart";
 import 'package:flutter/foundation.dart';
 import 'package:flutter/widgets.dart';
 import 'package:http/http.dart' as http;
@@ -230,6 +231,9 @@ class SuperLogging {
     StackTrace? stack,
   ) async {
     try {
+      if (error is DioError) {
+        return;
+      }
       await Sentry.captureException(
         error,
         stackTrace: stack,

diff --git a/mobile/lib/main.dart b/mobile/lib/main.dart
@@ -330,7 +330,7 @@ Future<void> _sync(String caller) async {
     await SyncService.instance.sync();
   } catch (e, s) {
     if (!isHandledSyncError(e)) {
-      _logger.severe("Sync error", e, s);
+      _logger.warning("Sync error", e, s);
     }
   }
 }

diff --git a/mobile/lib/services/collections_service.dart b/mobile/lib/services/collections_service.dart
@@ -729,7 +729,7 @@ class CollectionsService {
       collection.setName(newName);
       sync().ignore();
     } catch (e, s) {
-      _logger.severe("failed to rename collection", e, s);
+      _logger.warning("failed to rename collection", e, s);
       rethrow;
     }
   }

diff --git a/mobile/lib/services/user_service.dart b/mobile/lib/services/user_service.dart
@@ -276,7 +276,7 @@ class UserService {
         throw Exception("delete action failed");
       }
     } catch (e) {
-      _logger.severe(e);
+      _logger.warning(e);
       await showGenericErrorDialog(context: context, error: e);
       return null;
     }
@@ -304,7 +304,7 @@ class UserService {
         throw Exception("delete action failed");
       }
     } catch (e) {
-      _logger.severe(e);
+      _logger.warning(e);
       rethrow;
     }
   }
@@ -329,7 +329,7 @@ class UserService {
       }
       rethrow;
     } catch (e, s) {
-      _logger.severe("unexpected error", e, s);
+      _logger.warning("unexpected error", e, s);
       rethrow;
     }
   }
@@ -366,7 +366,7 @@ class UserService {
         Bus.instance.fire(AccountConfiguredEvent());
       }
     } catch (e) {
-      _logger.severe(e);
+      _logger.warning(e);
       await dialog.hide();
       await showGenericErrorDialog(context: context, error: e);
     }
@@ -448,7 +448,7 @@ class UserService {
       }
     } catch (e) {
       await dialog.hide();
-      _logger.severe(e);
+      _logger.warning(e);
       // ignore: unawaited_futures
       showErrorDialog(
         context,
@@ -519,7 +519,7 @@ class UserService {
       }
     } catch (e) {
       await dialog.hide();
-      _logger.severe(e);
+      _logger.warning(e);
       // ignore: unawaited_futures
       showErrorDialog(
         context,

diff --git a/mobile/lib/ui/viewer/gallery/gallery_app_bar_widget.dart b/mobile/lib/ui/viewer/gallery/gallery_app_bar_widget.dart
@@ -179,7 +179,7 @@ class _GalleryAppBarWidgetState extends State<GalleryAppBarWidget> {
             setState(() {});
           }
         } catch (e, s) {
-          _logger.severe("Failed to rename album", e, s);
+          _logger.warning("Failed to rename album", e, s);
           rethrow;
         }
       },
@@ -610,7 +610,7 @@ class _GalleryAppBarWidgetState extends State<GalleryAppBarWidget> {
         await dialog.hide();
         Navigator.of(context).pop();
       } catch (e, s) {
-        _logger.severe("failed to trash collection", e, s);
+        _logger.warning("failed to trash collection", e, s);
         await dialog.hide();
         await showGenericErrorDialog(context: context, error: e);
       }

diff --git a/mobile/lib/utils/file_uploader.dart b/mobile/lib/utils/file_uploader.dart
@@ -286,7 +286,7 @@ class FileUploader {
         kFileUploadTimeout,
         onTimeout: () {
           final message = "Upload timed out for file " + file.toString();
-          _logger.severe(message);
+          _logger.warning(message);
           throw TimeoutException(message);
         },
       );
@@ -1184,7 +1184,7 @@ class FileUploader {
             clearQueue(error);
             throw error;
           } else {
-            _logger.severe("Could not fetch upload URLs", e, s);
+            _logger.warning("Could not fetch upload URLs", e, s);
           }
         }
         rethrow;

diff --git a/mobile/lib/utils/file_uploader_util.dart b/mobile/lib/utils/file_uploader_util.dart
@@ -346,7 +346,7 @@ Future<MediaUploadData> _getMediaUploadDataFromAppCache(EnteFile file) async {
       width: dimensions?['width'],
     );
   } catch (e, s) {
-    _logger.severe("failed to generate thumbnail", e, s);
+    _logger.warning("failed to generate thumbnail", e, s);
     throw InvalidFileError(
       "thumbnail failed for appCache fileType: ${file.fileType.toString()}",
       InvalidReason.thumbnailMissing,