Add "About app" modal #9833
Merged
Add "About app" modal #9833
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
somebody1234
requested review from
PabloBuchu,
indiv0 and
MrFlashAccount
as code owners
somebody1234
added
CI: No changelog needed
| } | ||
|
|
||
| return ( | ||
| <Modal centered className="bg-dim"> |
There was a problem hiding this comment.
Please stop copypasting between components. We have Dialog component, use it instead
| const textContainerRef = React.useRef<HTMLTableSectionElement | null>(null) | ||
|
|
||
| const doCopy = () => { | ||
| const textContainer = textContainerRef.current |
There was a problem hiding this comment.
I think it'd be easier to understand if we build a string from existing variables(window.versionInfo and so forth), instead of trying to extract the information from html.
|
Also, I think we should be able to open the dialog via this menu as well |
|
There's also 1 missing thing: maybe we want to allow users to get the versions dialog on every screen(even on the login screen)? not only on the dashboard |
MrFlashAccount
requested changes
May 14, 2024
|
QA #1 ✅ Passed with a few moments to fix:
|
|
re 2: yeah. the intention was for chat to eventually work when logged out, but i guess it's not particularly useful as it is currently |
MrFlashAccount
approved these changes
May 14, 2024
somebody1234
added
the
CI: Ready to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
cmd+?Keybind Does Not Show Enso Version #9433Important Notes
None
Screenshots
In browser (both cloud entrypoint, and accessing
localhost:8080when the desktop app is running):On Electron desktop app:
On authentication pages:
(NOTE: Chat is present, but currently disabled as intended for users with the
isEnabledflag set tofalse. While it would be easy to change this to use the same chat API as the website, this is a design decision that is out of scope for this PR.)Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
The documentation has been updated, if necessary.Scala,
Java,
TypeScript,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.
Unit tests have been written where possible.