Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use InteropLibrary when accepting String values #9773

Merged
merged 2 commits into from
Apr 24, 2024
Merged

Use InteropLibrary when accepting String values #9773

merged 2 commits into from
Apr 24, 2024

Conversation

JaroslavTulach
Copy link
Member

@JaroslavTulach JaroslavTulach commented Apr 24, 2024 •
edited
Loading

Pull Request Description

While investigating #9749 a JavaScript call to Polyglot.eval("enso", ....).eval_expression("id") was made. It crashed as JavaScript isn't using String but TruffleString to represent strings.

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • All code follows the
    Java,
  • All code has been tested:
    • Unit tests have been written where possible.

@JaroslavTulach JaroslavTulach added the CI: No changelog needed Do not require a changelog entry for this PR. label Apr 24, 2024
@JaroslavTulach JaroslavTulach self-assigned this Apr 24, 2024
@JaroslavTulach JaroslavTulach mentioned this pull request Apr 24, 2024
Closed
@JaroslavTulach JaroslavTulach added CI: Clean build required CI runners will be cleaned before and after this PR is built. CI: Ready to merge This PR is eligible for automatic merge CI: Keep up to date Automatically update this PR to the latest develop. labels Apr 24, 2024
@mergify mergify bot merged commit a786ad2 into develop Apr 24, 2024
35 of 36 checks passed
@mergify mergify bot deleted the wip/jtulach/Iop9749 branch April 24, 2024 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hubertp hubertp hubertp approved these changes

@4e6 4e6 Awaiting requested review from 4e6 4e6 is a code owner

@Akirathan Akirathan Awaiting requested review from Akirathan Akirathan is a code owner

Assignees

@JaroslavTulach JaroslavTulach

Labels
CI: Clean build required CI runners will be cleaned before and after this PR is built. CI: Keep up to date Automatically update this PR to the latest develop. CI: No changelog needed Do not require a changelog entry for this PR. CI: Ready to merge This PR is eligible for automatic merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JaroslavTulach @hubertp