-
Notifications
You must be signed in to change notification settings - Fork 326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"User groups" settings page #9081
Conversation
TODO: UI for adding/deleting user groups; testing
Sorry we made you waiting with this. Member Roles
Members
|
member roles:
members:
|
|
Yea shadow is great, and together with margins should be an awesome solution |
I haven't seen your solution for tooltips yet, but I assume it's because they are inside the element with ellipsis applied. Moving it away from the container should fix the issue. |
note that i've more or less removed margins for now. |
still no clue why point 7 is broken unfortunately |
I did a fix in your branch, now it should be ok |
@MrFlashAccount doesn't work unfortunately. i've tried that before, and just tested it out on the current commit. (no tooltip + blank line) |
16ade8f
to
06f25dd
Compare
06f25dd
to
95629d5
Compare
QA ✅ Nice work, @somebody1234 ! |
Pull Request Description
Other changes:
Important Notes
None
Testing Instructions
Just the new "User Groups" page, and testing deletion of users in the "Members" page
Screenshots
User groups table:
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
The documentation has been updated, if necessary.Scala,
Java,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.
Unit tests have been written where possible.If GUI codebase was changed, the GUI was tested when built using./run ide build
.