Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moving PackageRepository.Default into its own EnsoPackageRepository #7395

Merged
merged 2 commits into from
Jul 26, 2023

Conversation

JaroslavTulach
Copy link
Member

@JaroslavTulach JaroslavTulach commented Jul 25, 2023

Pull Request Description

PackageRepository is a trait, yet its .scala file also includes implementation. While the trait is relatively lightweight, the implementation requires way more heavyweight dependencies. For example it depends on EnsoContext.

If we want to eliminate dependency of Compiler on EnsoContext, we'd rather split the trait and implementation of the package repository into two files and move the newly created EnsoPackageRepository implementation next to EnsoContext (which creates its instance).

Important Notes

This is just a refactoring. Functionally wise the behavior shall remain the same.

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • All code follows the
    Scala,
    Java,
  • All code has been tested:
    • Unit tests continue to pass

@JaroslavTulach JaroslavTulach added the CI: No changelog needed Do not require a changelog entry for this PR. label Jul 25, 2023
@JaroslavTulach JaroslavTulach self-assigned this Jul 25, 2023
@JaroslavTulach JaroslavTulach added the CI: Keep up to date Automatically update this PR to the latest develop. label Jul 26, 2023
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rename this file to DefaultPackageRepository.scala, or rename the class here to EnsoPackageRepository too keep it consistent.

@JaroslavTulach JaroslavTulach merged commit f2c4642 into develop Jul 26, 2023
@JaroslavTulach JaroslavTulach deleted the wip/jtulach/EnsoPackageRepository branch July 26, 2023 07:59
@enso-bot
Copy link

enso-bot bot commented Jul 27, 2023

Jaroslav Tulach reports a new STANDUP for yesterday (2023-07-26):

Progress: - merged EnsoPackageRepository: #7395

Next Day: Interop with Python

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI: Keep up to date Automatically update this PR to the latest develop. CI: No changelog needed Do not require a changelog entry for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants