Moving PackageRepository.Default into its own EnsoPackageRepository #7395
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
PackageRepository
is atrait
, yet its.scala
file also includes implementation. While the trait is relatively lightweight, the implementation requires way more heavyweight dependencies. For example it depends onEnsoContext
.If we want to eliminate dependency of
Compiler
onEnsoContext
, we'd rather split the trait and implementation of the package repository into two files and move the newly createdEnsoPackageRepository
implementation next toEnsoContext
(which creates its instance).Important Notes
This is just a refactoring. Functionally wise the behavior shall remain the same.
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,