-
Notifications
You must be signed in to change notification settings - Fork 326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check for PanicSentinel in SequenceLiteralNode #7385
Check for PanicSentinel in SequenceLiteralNode #7385
Conversation
One thing to note here – a |
3969890
to
0c6900e
Compare
Thank you Marcin. Rewritten to just |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's much better than wrapping it in a warning 👍
Don't forget to update the PR title |
Pull Request Description
Fixes #7245.
The above picture shows that the vector problem reported by #7245 is fixed.
Important Notes
The fix modifies
SequenceLiteralNode
to recognizePanicSentinel
andthrow
it as common in other places (like invoke function node, etc.).Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,