Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vector.map & State #7078

Merged
merged 10 commits into from
Jun 26, 2023
Merged

Vector.map & State #7078

merged 10 commits into from
Jun 26, 2023

Conversation

JaroslavTulach
Copy link
Member

@JaroslavTulach JaroslavTulach commented Jun 20, 2023 •
edited
Loading

Pull Request Description

Fixes #6656 by invoking the function with InvokeFunctionNode and not InteropLibrary.

Important Notes

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • All code follows the
    Java,
  • All code has been tested:
    • Unit tests have been written where possible.

@JaroslavTulach JaroslavTulach added the CI: No changelog needed Do not require a changelog entry for this PR. label Jun 20, 2023
@JaroslavTulach JaroslavTulach self-assigned this Jun 20, 2023
@enso-bot enso-bot bot mentioned this pull request Jun 21, 2023
Closed
@JaroslavTulach
Copy link
Member Author

With a24134d I can see

image

I hope that's correct. Now we need to "just" write some tests and polish the implementation.

@JaroslavTulach JaroslavTulach requested a review from kustosz June 21, 2023 06:57
kustosz
kustosz reviewed Jun 21, 2023
View reviewed changes
engine/runtime/src/main/java/org/enso/interpreter/runtime/data/Vector.java Outdated
return InvokeFunctionNode.build(
new CallArgumentInfo[] {new CallArgumentInfo()},
InvokeCallableNode.DefaultsExecutionMode.EXECUTE,
InvokeCallableNode.ArgumentsExecutionMode.EXECUTE);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can probably experiment with removing arguments execution mode. It's a leftover from a bygone era and the only thing it potentially does is a tiny performance improvement. But I'm not sure it does, so better check.

@JaroslavTulach
Copy link
Member Author

@kustosz : Why is select_into_database_table a Text and not an UnresolvedSymbol:

Meta.get_annotation object .annotation_name

There is an API to evaluate any expression in any module.

@JaroslavTulach JaroslavTulach changed the title Vector.map & State & Meta.get_annotation Vector.map & State Jun 23, 2023
@JaroslavTulach
Copy link
Member Author

This PR has been simplified to fix just the Vector.map & State. Fix for annotations on extension functions is now part of #7115.

@radeusgd
Copy link
Member

I've just found a slightly related issue #7117 showing that while definitely a step in the right direction, this may still not be enough.

@JaroslavTulach JaroslavTulach merged commit c4f19e7 into develop Jun 26, 2023
@JaroslavTulach JaroslavTulach deleted the wip/jtulach/InstrumentationState_6955 branch June 26, 2023 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hubertp hubertp hubertp approved these changes

@radeusgd radeusgd radeusgd approved these changes

@GregoryTravis GregoryTravis GregoryTravis approved these changes

@jdunkerley jdunkerley Awaiting requested review from jdunkerley jdunkerley is a code owner

@4e6 4e6 Awaiting requested review from 4e6 4e6 is a code owner

@Akirathan Akirathan Awaiting requested review from Akirathan Akirathan is a code owner

@kustosz kustosz Awaiting requested review from kustosz

Assignees

@JaroslavTulach JaroslavTulach

Labels
CI: No changelog needed Do not require a changelog entry for this PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

State is lost inside of Vector.map
6 participants
@JaroslavTulach @radeusgd @hubertp @kustosz @Akirathan @GregoryTravis