Enable React and strict-boolean-expressions lints
#7023
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
somebody1234
added
the
CI: No changelog needed
5 tasks
somebody1234
requested review from
PabloBuchu,
indiv0,
MichaelMauderer and
wdanilo
as code owners
wdanilo
approved these changes
Jun 16, 2023
|
@somebody1234 What's the status here? It's 3 days old w/o any action. |
|
@xvcgreg Sorry - it's waiting on QA, just posted in QA-requests |
|
It was previously blocked by #7022, which is now merged in |
@somebody1234 |
indiv0
requested changes
Jun 19, 2023
app/ide-desktop/lib/dashboard/src/authentication/src/dashboard/components/contextMenuEntry.tsx
Show resolved
Hide resolved
app/ide-desktop/lib/dashboard/src/authentication/src/dashboard/components/modal.tsx
Show resolved
Hide resolved
|
❌ QA failed; 12 issues, 1 untested Scenario Descriptions
Scenario 0./run gui watch \
--skip-wasm-opt \
--wasm-profile=dev \
--skip-version-check \
--profiling-level=objective \
--wasm-log-level=info \
--wasm-uncollapsed-log-level=info
Screenshot(s)/screencast(s)
Scenario 1ENSO_BUILD_TARGET=dir \
./run ide watch \
--skip-wasm-opt \
--wasm-profile=dev \
--backend-source=local \
--backend-release=nightly \
--skip-version-check \
--profiling-level=objective \
--wasm-log-level=info \
--wasm-uncollapsed-log-level=info \
--ide-option=-feature-preview.new-dashboard \
--ide-option=-debug.dev-tools \
--ide-option=-debug \
--ide-option=--inspect=5858 \
--ide-option=-authentication \
--ide-option=-startup.entry=text_area
Screenshot(s)/screencast(s)
Scenario 2ENSO_BUILD_TARGET=dir \
./run ide watch \
--skip-wasm-opt \
--wasm-profile=dev \
--backend-source=local \
--backend-release=nightly \
--skip-version-check \
--profiling-level=objective \
--wasm-log-level=info \
--wasm-uncollapsed-log-level=info \
--ide-option=-feature-preview.new-dashboard \
--ide-option=-debug.dev-tools \
--ide-option=-debug \
--ide-option=--inspect=5858 \
--ide-option=-authentication
Screenshot(s)/screencast(s)
Failed to open local project:
React setState() error when opening local project:
Font atlas not found when opening local project:
Error logs when opening cloud project
Error logs when opening selection menu for new node in cloud project
Error logs when opening local project
React setState() error when opening local project
Font atlas metadata file not found when opening local project:
Scenario 3ENSO_BUILD_TARGET=dir \
./run ide build \
--skip-wasm-opt \
--wasm-profile=dev \
--backend-source=local \
--backend-release=nightly \
--skip-version-check \
--profiling-level=objective \
--wasm-log-level=info \
--wasm-uncollapsed-log-level=info
./dist/ide/mac-arm64/Enso.app/Contents/MacOS/Enso \
-feature-preview.new-dashboard \
-debug.dev-tools \
-debug \
--inspect=5858 \
-authentication
Screenshot(s)/screencast(s)
Local project does not open:
Local project does not open error logs:
More error logs from terminal: Scenario 4cd app/ide-desktop
npm run build-dashboard
Screenshot(s)/screencast(s)
Scenario 5cd app/ide-desktop
npm run watch-dashboard
Screenshot(s)/screencast(s)
Selection menu contains no text:
Error logs for selection menu: |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
Overall: a lot of hard to hunt bugs :(
|
2 tasks
|
At least some of the selection menu & cloud execution issues are being tracked at #7060 and #7061. Re-QA is blocked until those are fixed, so I'll hold off on that for now. Side-note: If you wouldn't mind, please let me resolve the conversations once they've been addressed, otherwise it gets a bit tricky to track what has changed since the last review. |
2 tasks
|
@indiv0 please check if we can proceed with this issue |
|
@indiv0 I took a look on this PR and seems to be fine. Please let me know if everything is solved and can it be merged? |
indiv0
approved these changes
Jul 5, 2023
PabloBuchu
added
the
CI: Clean build required
PabloBuchu
removed
the
CI: Clean build required
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
strict-boolean-expressionsESLint lintImportant Notes
A lot of files have been changed, but the vast majority are because of the
react->Reactname change enforced by the lintsreact->ReactandtruthyValue->truthyValue != null), and adding dependencies to React hooks. If there are other code changes, it is probably a mistake and should probably be reported.Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
The documentation has been updated, if necessary.Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.Scala,
Java,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.
Unit tests have been written where possible.If GUI codebase was changed, the GUI was tested when built using./run ide build.