-
Notifications
You must be signed in to change notification settings - Fork 326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add round, ceil, floor, truncate to the In-Database Column type #6988
Merged
Merged
Changes from 2 commits
Commits
Show all changes
89 commits
Select commit
Hold shift + click to select a range
bbc5cff
one test
GregoryTravis e6bed7b
function_name
GregoryTravis 347b46e
expression_spec
GregoryTravis c78560d
gmt test
GregoryTravis 2fa1846
sl
GregoryTravis 8291ce3
Merge branch 'develop' into wip/gmt/6886-truncate
GregoryTravis b16d9ee
trunc tests
GregoryTravis be81b60
ceil floor
GregoryTravis 3b486b9
by hand rounding, sqlite parser stack overflow
GregoryTravis 9fe0841
wip
GregoryTravis f649b73
pg maybe smaller
GregoryTravis 2f68d35
works in sqlite too
GregoryTravis 7f7324b
col math works
GregoryTravis 9c4e0ff
clean up
GregoryTravis abaab2a
tests, cast to int column
GregoryTravis e20161a
rounding tests
GregoryTravis f42285e
round expression spec
GregoryTravis d802271
int in int out
GregoryTravis f05f9e3
full col tests
GregoryTravis ccda6aa
round to float
GregoryTravis 4ff6fa7
dp out of range
GregoryTravis 5b41821
const tests
GregoryTravis 93f4403
rename to const, name test
GregoryTravis c60d354
nulls
GregoryTravis a25e3d5
remove pow_flip
GregoryTravis 5283255
make trunc, ceil, floor generic
GregoryTravis 4aed89c
do not restrict const arg
GregoryTravis 50b78eb
Merge branch 'develop' into wip/gmt/6886-truncate
GregoryTravis fbecfd8
review
GregoryTravis 593982b
nan/inf docs
GregoryTravis 3ff04b5
changelog
GregoryTravis 05fc15e
decimal too
GregoryTravis 3fe8280
restore deleted test, restore integrity check
GregoryTravis 31874a8
const not an op, using make_constant
GregoryTravis 9256930
wip
GregoryTravis 03f3e05
in-mem const
GregoryTravis 78aa29f
share with eval exp
GregoryTravis 92b4d49
factor out dp check
GregoryTravis 8d19564
only test decimal on pg-like
GregoryTravis 91d58b2
column arithmetic for in-mem too
GregoryTravis ea10375
wip
GregoryTravis b7b6d3e
symmetric
GregoryTravis e8dbf9f
symmetric for in-mem
GregoryTravis 218f2e2
symmetric for db
GregoryTravis 570756d
wip
GregoryTravis afd21ac
integer impl
GregoryTravis b0c771e
wip
GregoryTravis bbd7033
col col
GregoryTravis e891c44
unstable
GregoryTravis 511a627
review
GregoryTravis 9769faf
pg/sl return type
GregoryTravis 41bd417
more type checks for in-mem
GregoryTravis 4d0627b
input check for in-mem round
GregoryTravis 0ad7ef4
use make_function
GregoryTravis 0a350c2
wip
GregoryTravis d6fe5ce
wrapper
GregoryTravis 395a3b6
round_decimal
GregoryTravis 10fa61c
sl
GregoryTravis 086fb18
round etc return types
GregoryTravis c6fed25
rename round_with
GregoryTravis 6351dce
cleanup
GregoryTravis c27b52d
docs
GregoryTravis 314546d
decimal test
GregoryTravis 7fcb5c7
specialize
GregoryTravis 3bac313
remove max_long test
GregoryTravis 05620e4
p flag for dp restriction
GregoryTravis 307f9f0
rs too
GregoryTravis 021a2f4
return type tests
GregoryTravis 6ed5154
bankers
GregoryTravis 519f329
cleanup
GregoryTravis c6d7974
merge
GregoryTravis 934f974
Merge branch 'develop' into wip/gmt/6886-truncate
GregoryTravis 35fe5b1
literal for dp
GregoryTravis 076172a
changelog chronological
GregoryTravis 3a9b1d7
review
GregoryTravis 819e75f
undo changelog
GregoryTravis bfce3b7
precision too high
GregoryTravis e13e178
Merge branch 'develop' into wip/gmt/6886-truncate
GregoryTravis 9d3f548
wip
GregoryTravis 4895366
trunc
GregoryTravis 6342238
DoubleLongMapOpWithSpecialNumericHandling
GregoryTravis c22364e
wip
GregoryTravis 7b16564
fmt
GregoryTravis 2ca4084
Merge branch 'develop' into wip/gmt/6886-truncate
GregoryTravis bc6f8fa
precision limit tests
GregoryTravis 9905ac3
fixed
GregoryTravis 74f00d3
cleanup
GregoryTravis 40d2376
epsilon
GregoryTravis 9ff2ef6
another epsilon
GregoryTravis File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please remove these random letters though :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done