-
Notifications
You must be signed in to change notification settings - Fork 326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix unclosed console.group
and overhaul logging in loader.ts
#6979
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wdanilo
approved these changes
Jun 9, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, but please do in-depth QA that everything loads correctly after these changes :)
TL;DR: QA passed successfully Scenario 0./run gui watch \
--skip-wasm-opt \
--skip-version-check
Scenario 1ENSO_BUILD_TARGET=dir \
./run ide watch \
--skip-wasm-opt \
--wasm-profile=dev \
--backend-source=release \
--backend-release=nightly \
--skip-version-check \
--ide-option=-feature-preview.new-dashboard \
--ide-option=-debug.dev-tools \
--ide-option=-debug \
--ide-option=--inspect=5858 \
--ide-option=-authentication \
--ide-option=-startup.entry=text_area
Scenario 2ENSO_BUILD_TARGET=dir \
./run ide watch \
--skip-wasm-opt \
--wasm-profile=dev \
--backend-source=release \
--backend-release=nightly \
--skip-version-check \
--profiling-level=objective \
--wasm-log-level=info \
--wasm-uncollapsed-log-level=info \
--ide-option=-feature-preview.new-dashboard \
--ide-option=-debug.dev-tools \
--ide-option=-debug \
--ide-option=--inspect=5858 \
--ide-option=-authentication
ensogl::define_endpoints! { with: ensogl::define_endpoints! { [TRACE_ALL]
Scenario 3ENSO_BUILD_TARGET=dir \
./run ide watch \
--skip-wasm-opt \
--wasm-profile=dev \
--backend-source=release \
--backend-release=nightly \
--skip-version-check \
--profiling-level=objective \
--wasm-log-level=info \
--wasm-uncollapsed-log-level=info \
--ide-option=-debug.dev-tools \
--ide-option=-debug \
--ide-option=--inspect=5858 \
--ide-option=-startup.entry=text_area
Scenario 4ENSO_BUILD_TARGET=dir \
./run ide watch \
--skip-wasm-opt \
--wasm-profile=dev \
--backend-source=release \
--backend-release=nightly \
--skip-version-check \
--profiling-level=objective \
--wasm-log-level=info \
--wasm-uncollapsed-log-level=info \
--ide-option=-debug.dev-tools \
--ide-option=-debug \
--ide-option=--inspect=5858
ensogl::define_endpoints! { with: ensogl::define_endpoints! { [TRACE_ALL]
Scenario 5ENSO_BUILD_TARGET=dir \
./run ide build \
--skip-wasm-opt \
--wasm-profile=dev \
--backend-source=release \
--backend-release=nightly \
--skip-version-check \
--profiling-level=objective \
--wasm-log-level=info \
--wasm-uncollapsed-log-level=info
./dist/ide/mac-arm64/Enso.app/Contents/MacOS/Enso \
-feature-preview.new-dashboard \
-debug.dev-tools \
-debug \
--inspect=5858 \
-authentication Scenario 6cd app/ide-desktop
npm run build-dashboard
Scenario 7cd app/ide-desktop
npm run watch-dashboard
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Important Notes
The linked issue is actually a combination of two issues - but the other (the cloud IDE using a different version of
pkg.wasm
) is unsolvable as that is intended behaviorChecklist
Please ensure that the following checklist has been satisfied before submitting the PR:
The documentation has been updated, if necessary.Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.Scala,
Java,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.
Unit tests have been written where possible.If GUI codebase was changed, the GUI was tested when built using./run ide build
.