Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unclosed console.group and overhaul logging in loader.ts #6979

Merged
merged 1 commit into from
Jun 15, 2023

Conversation

somebody1234
Copy link
Contributor

Pull Request Description

Important Notes

The linked issue is actually a combination of two issues - but the other (the cloud IDE using a different version of pkg.wasm) is unsolvable as that is intended behavior

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • All code has been tested:
    • Unit tests have been written where possible.
    • If GUI codebase was changed, the GUI was tested when built using ./run ide build.

@somebody1234 somebody1234 added the CI: No changelog needed Do not require a changelog entry for this PR. label Jun 7, 2023
Copy link
Member

@wdanilo wdanilo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but please do in-depth QA that everything loads correctly after these changes :)

@indiv0
Copy link
Contributor

indiv0 commented Jun 14, 2023

TL;DR: QA passed successfully

Scenario 0

./run gui watch \
    --skip-wasm-opt \
    --skip-version-check

Scenario 1

ENSO_BUILD_TARGET=dir \
    ./run ide watch \
    --skip-wasm-opt \
    --wasm-profile=dev \
    --backend-source=release \
    --backend-release=nightly \
    --skip-version-check \
    --ide-option=-feature-preview.new-dashboard \
    --ide-option=-debug.dev-tools \
    --ide-option=-debug \
    --ide-option=--inspect=5858 \
    --ide-option=-authentication \
    --ide-option=-startup.entry=text_area
  • ✅ Debug scene is visible
  • ✅ Logs appear with console.log("Hello")
Screenshot
image

Scenario 2

ENSO_BUILD_TARGET=dir \
    ./run ide watch \
    --skip-wasm-opt \
    --wasm-profile=dev \
    --backend-source=release \
    --backend-release=nightly \
    --skip-version-check \
    --profiling-level=objective \
    --wasm-log-level=info \
    --wasm-uncollapsed-log-level=info \
    --ide-option=-feature-preview.new-dashboard \
    --ide-option=-debug.dev-tools \
    --ide-option=-debug \
    --ide-option=--inspect=5858 \
    --ide-option=-authentication
ensogl::define_endpoints! {

with:

ensogl::define_endpoints! { [TRACE_ALL]
  • ✅ Nodes in Cloud project are visible
  • [INFO] logs appear in console
  • ✅ Logs appear with console.log("Hello")
  • ✅ FRP logs appear in the output
Screenshot image

Scenario 3

ENSO_BUILD_TARGET=dir \
    ./run ide watch \
    --skip-wasm-opt \
    --wasm-profile=dev \
    --backend-source=release \
    --backend-release=nightly \
    --skip-version-check \
    --profiling-level=objective \
    --wasm-log-level=info \
    --wasm-uncollapsed-log-level=info \
    --ide-option=-debug.dev-tools \
    --ide-option=-debug \
    --ide-option=--inspect=5858 \
    --ide-option=-startup.entry=text_area
  • ✅ Debug scene is visible
  • ✅ Logs appear with console.log("Hello")
Screenshot image

Scenario 4

ENSO_BUILD_TARGET=dir \
    ./run ide watch \
    --skip-wasm-opt \
    --wasm-profile=dev \
    --backend-source=release \
    --backend-release=nightly \
    --skip-version-check \
    --profiling-level=objective \
    --wasm-log-level=info \
    --wasm-uncollapsed-log-level=info \
    --ide-option=-debug.dev-tools \
    --ide-option=-debug \
    --ide-option=--inspect=5858
ensogl::define_endpoints! {

with:

ensogl::define_endpoints! { [TRACE_ALL]
  • ✅ Nodes in Cloud project are visible
  • [INFO] logs appear in console
  • ✅ Logs appear with console.log("Hello")
  • ✅ FRP logs appear in the output
Screenshot image

Scenario 5

ENSO_BUILD_TARGET=dir \
    ./run ide build \
    --skip-wasm-opt \
    --wasm-profile=dev \
    --backend-source=release \
    --backend-release=nightly \
    --skip-version-check \
    --profiling-level=objective \
    --wasm-log-level=info \
    --wasm-uncollapsed-log-level=info
./dist/ide/mac-arm64/Enso.app/Contents/MacOS/Enso \
    -feature-preview.new-dashboard \
    -debug.dev-tools \
    -debug \
    --inspect=5858 \
    -authentication
Screenshot image

Scenario 6

cd app/ide-desktop
npm run build-dashboard
  • ✅ Command ran successfully
Screenshot image

Scenario 7

cd app/ide-desktop
npm run watch-dashboard
  • ✅ Command ran successfully
Screenshot image

@indiv0 indiv0 merged commit 7c6ddf4 into develop Jun 15, 2023
@indiv0 indiv0 deleted the wip/sb/fix-unclosed-console-group branch June 15, 2023 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI: No changelog needed Do not require a changelog entry for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IDE logging not working when opening cloud project
3 participants