Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Search for IR.Function deeper in the IR tree to find instance methods #6902

Merged
merged 3 commits into from
May 31, 2023
Merged

Search for IR.Function deeper in the IR tree to find instance methods #6902

merged 3 commits into from
May 31, 2023

Conversation

JaroslavTulach
Copy link
Member

@JaroslavTulach JaroslavTulach commented May 30, 2023 •
edited
Loading

Pull Request Description

Fixes #6891 by going deeper into the IR tree to find more IR.Function instances.

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • All code follows the
    Java,
  • All code has been tested:
    • Unit tests have been written where possible.

@JaroslavTulach JaroslavTulach added the CI: No changelog needed Do not require a changelog entry for this PR. label May 30, 2023
@JaroslavTulach JaroslavTulach requested a review from radeusgd May 30, 2023 16:45
@JaroslavTulach JaroslavTulach self-assigned this May 30, 2023
radeusgd
radeusgd reviewed May 30, 2023
View reviewed changes
Copy link
Member

@radeusgd radeusgd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this also fix the in-line case?

i.e.

foo x =
    bar (y : Integer) = y+y
    bar x

@JaroslavTulach JaroslavTulach mentioned this pull request May 30, 2023
Closed
@JaroslavTulach
Copy link
Member Author

JaroslavTulach commented May 30, 2023 •
edited
Loading

Does this also fix the in-line case?

i.e.

foo x =
    bar (y : Integer) = y+y
    bar x

Yes, it does: tested in 835e07b

@enso-bot enso-bot bot mentioned this pull request May 31, 2023
Closed
@JaroslavTulach JaroslavTulach merged commit bc6b9bc into develop May 31, 2023
@JaroslavTulach JaroslavTulach deleted the wip/jtulach/InstanceMethodArgsCheck_6891 branch May 31, 2023 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@radeusgd radeusgd radeusgd left review comments

@hubertp hubertp hubertp approved these changes

@Akirathan Akirathan Akirathan approved these changes

@4e6 4e6 Awaiting requested review from 4e6 4e6 is a code owner

Assignees

@JaroslavTulach JaroslavTulach

Labels
CI: No changelog needed Do not require a changelog entry for this PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Runtime check of ascribed types works only for static methods
4 participants
@JaroslavTulach @hubertp @radeusgd @Akirathan