Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Project Manager when on local backend #6807

Closed
wants to merge 1 commit into from

Conversation

somebody1234
Copy link
Contributor

@somebody1234 somebody1234 commented May 23, 2023

Pull Request Description

Temporary workaround (?) while GUI still depends on the Project Manager for certain actions.
I think the issues should still be open (assuming the intent is still to move away from the old projects list), but maybe they should go in the backlog instead.

This fixes features relying on the Project Manager:

Important Notes

  • It has been brought up that the dashboard does project/open, and then the IDE does project/open again. It's possible to work around this on the dashboard side, but I'm not sure whether the added complexity is worth the performance improvements in avoiding opening the same project twice.

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • All code has been tested:
    • Unit tests have been written where possible.
    • If GUI codebase was changed, the GUI was tested when built using ./run ide build.

@somebody1234 somebody1234 added the CI: No changelog needed Do not require a changelog entry for this PR. label May 23, 2023
@somebody1234 somebody1234 deleted the wip/sb/use-pm-for-local-backend branch December 7, 2023 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI: No changelog needed Do not require a changelog entry for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant