Disable cloud backend for unverified users; use local backend as default backend; minor bugfixes #6779
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
somebody1234
added
the
CI: No changelog needed
somebody1234
changed the title
|
QA 🟢 we should merge it I guess as soon as possible. @sylwiabr you want to give it a try? |
PabloBuchu
approved these changes
May 19, 2023
|
added two minor fixes, which should not affect QA results as they are extremely minor. |
somebody1234
changed the title
This reverts commit 5974170.
wdanilo
approved these changes
May 23, 2023
Procrat
added a commit
that referenced
this pull request
May 23, 2023
* develop: Use state sent with `GET /directories` instead of querying state separately (#6794) Run TypeScript typechecking and eslint on Lint CI (#6603) Disable cloud backend for unverified users; use local backend as default backend; minor bugfixes (#6779) Reloading file in LS after desynchronization. (#6752) Missing conversion of hash key in EqualsNode (#6803) feat: set constructor args tag values (#6801)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Important Notes
A lot of lines of code show as changed, but that's mostly a side effect of
dashboard.tsxcurrently being monolithic.This PR also fixes a minor bug with the service workers, that prevent them from properly handling URLs with query parameters.
Screenshots
Screenshot taken on cloud frontend, which is why the backend switcher is not visible.
It has been tested on
ide watchas well.Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.
./run ide build.