Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removing flush #6670

Merged
merged 1 commit into from
May 12, 2023
Merged

Removing flush #6670

merged 1 commit into from
May 12, 2023

Conversation

wdanilo
Copy link
Member

@wdanilo wdanilo commented May 12, 2023

Pull Request Description

Removes one gl.flush() call. We are doing flush every frame, and this one causes 2 flushes per frame sometimes, which can negatively affect the performance.

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • All code has been tested:
    • Unit tests have been written where possible.
    • If GUI codebase was changed, the GUI was tested when built using ./run ide build.

@wdanilo wdanilo added the CI: No changelog needed Do not require a changelog entry for this PR. label May 12, 2023
@wdanilo wdanilo marked this pull request as ready for review May 12, 2023 15:56
kazcw
kazcw approved these changes May 12, 2023
View reviewed changes
Copy link
Contributor

@kazcw kazcw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable.

@wdanilo wdanilo merged commit 32fd228 into develop May 12, 2023
@wdanilo wdanilo deleted the wip/wd/no-flush branch May 12, 2023 16:10
Procrat added a commit that referenced this pull request May 15, 2023
@Procrat
Merge branch 'develop' into wip/procrat/shift-space-for-fullscreen-vi…
cc7daae 
…z-6260

* develop:
  Build nightlies every day. (#6681)
  Force `newDashboard` default on the CI-built packages. (#6680)
  Verify ascribed types of parameters really exist (#6584)
  SuggestionBuilder needs to send ascribedType of constructor parameters (#6655)
  Improvements to the Table visualization. (#6653)
  Removing flush (#6670)
  Improving widgets for take/drop (#6641)
Procrat added a commit that referenced this pull request May 16, 2023
@Procrat
Merge branch 'develop' into wip/procrat/home-button-6399
030cbe7 
* develop:
  Build nightlies every day. (#6681)
  Force `newDashboard` default on the CI-built packages. (#6680)
  Verify ascribed types of parameters really exist (#6584)
  SuggestionBuilder needs to send ascribedType of constructor parameters (#6655)
  Improvements to the Table visualization. (#6653)
  Removing flush (#6670)
  Improving widgets for take/drop (#6641)
  disable authentication and newDashboard by default (#6664)
  Add COOP+COEP+CORP headers (#6646)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kazcw kazcw kazcw approved these changes

@MichaelMauderer MichaelMauderer Awaiting requested review from MichaelMauderer

@farmaazon farmaazon Awaiting requested review from farmaazon farmaazon is a code owner

Assignees
No one assigned
Labels
CI: No changelog needed Do not require a changelog entry for this PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wdanilo @kazcw