Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Proper handling of multiple list views. #6461

Merged
merged 12 commits into from
May 1, 2023
Merged

Proper handling of multiple list views. #6461

merged 12 commits into from
May 1, 2023

Conversation

wdanilo
Copy link
Member

@wdanilo wdanilo commented Apr 27, 2023 •
edited
Loading

Pull Request Description

This PR improves how List Editor work, allowing multiple List Editors to co-exist:

  1. It allows dragging items between list editors.
  2. When there are no more items, it displays a button allowing adding new items.
Screen.Recording.2023-05-01.at.08.05.05.mov

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • All code has been tested:
    • Unit tests have been written where possible.
    • If GUI codebase was changed, the GUI was tested when built using ./run ide build.

@wdanilo wdanilo marked this pull request as ready for review April 28, 2023 04:50
@wdanilo wdanilo added the CI: No changelog needed Do not require a changelog entry for this PR. label Apr 28, 2023
@wdanilo wdanilo requested a review from Frizi April 28, 2023 04:54
@wdanilo wdanilo changed the title Wip/wd/vector editor6 Proper handling of multiple list views. May 1, 2023
@wdanilo wdanilo merged commit cd92d90 into develop May 1, 2023
@wdanilo wdanilo deleted the wip/wd/vector-editor6 branch May 1, 2023 16:11
Procrat added a commit that referenced this pull request May 2, 2023
@Procrat
Merge branch 'develop' into wip/procrat/home-button-6399
4234c47 
* develop:
  Finishing Vector Editor (#6470)
  Proper handling of multiple list views. (#6461)
  Fix disappearing cached shapes (#6458)
  Add Execution Context control to Text.write (#6459)
  Change defaults for `Connection.tables` and ensure that `Connection.query` recognizes all available tables (#6443)
@vitvakatu vitvakatu mentioned this pull request May 3, 2023
Closed
2 tasks
Procrat added a commit that referenced this pull request May 3, 2023
@Procrat
Merge branch 'develop' into wip/procrat/json-viz-last-row-6196
b63966e 
* develop: (34 commits)
  Continued Execution Context work and some little fixes (#6506)
  IDE's logging to a file (#6478)
  Fix application config (#6513)
  Cloud/desktop mode switcher (#6448)
  Fix doubled named arguments bug (#6422)
  Reimplement `enso_project` as a proper builtin (#6352)
  Fix layer ordering between dropdown and breadcrumbs backgrounds.  (#6483)
  Multiflavor layers (#6477)
  DataflowAnalysis preserves dependencies order (#6493)
  Implement `create_database_table` for Database Table (#6467)
  Limit Dead Letter logging (#6482)
  More reliable shutdown of the EnsoContext to save resources (#6468)
  Make execution mode `live` default for CLI (#6496)
  Finishing Vector Editor (#6470)
  Proper handling of multiple list views. (#6461)
  Fix disappearing cached shapes (#6458)
  Add Execution Context control to Text.write (#6459)
  Change defaults for `Connection.tables` and ensure that `Connection.query` recognizes all available tables (#6443)
  Introducing @BuiltinMethod.needsFrame and InlineableNode (#6442)
  Hide profile button behind a feature flag (#6430)
  ...
@sylwiabr sylwiabr mentioned this pull request May 5, 2023
Closed
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@farmaazon farmaazon farmaazon approved these changes

@MichaelMauderer MichaelMauderer Awaiting requested review from MichaelMauderer

@kazcw kazcw Awaiting requested review from kazcw kazcw is a code owner

@mwu-tow mwu-tow Awaiting requested review from mwu-tow

@Frizi Frizi Awaiting requested review from Frizi Frizi is a code owner

Assignees
No one assigned
Labels
CI: No changelog needed Do not require a changelog entry for this PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wdanilo @farmaazon