Fix: when default visualization is displayed, its entry is not present in the chooser list. #6209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
farmaazon
added
the
CI: No changelog needed
farmaazon
requested review from
MichaelMauderer,
wdanilo and
kazcw
as code owners
vitvakatu
reviewed
Apr 5, 2023
app/gui/view/graph-editor/src/component/visualization/container.rs
Outdated
Show resolved
Hide resolved
…r.rs Co-authored-by: Ilya Bogdanov <[email protected]>
wdanilo
approved these changes
Apr 10, 2023
|
@vitvakatu @MichaelMauderer can one of you QA this? |
|
I will check it |
vitvakatu
approved these changes
Apr 11, 2023
There was a problem hiding this comment.
QA: passed. Also, I wasn't able to reproduce #5991 on this branch, but it needs to be checked separately. cc @MichaelMauderer
wdanilo
approved these changes
Apr 11, 2023
| selected_definition <- action_bar.visualisation_selection.map(f!([registry](path) | ||
| path.as_ref().and_then(|path| registry.definition_from_path(path)) | ||
| )); | ||
| on_selected <- selected_definition.map(|d|d.as_ref().map(|_|())).unwrap(); |
| path.as_ref().and_then(|path| registry.definition_from_path(path)) | ||
| )); | ||
| on_selected <- selected_definition.map(|d|d.as_ref().map(|_|())).unwrap(); | ||
| eval_ on_selected ( action_bar.hide_icons.emit(()) ); |
There was a problem hiding this comment.
action_bar.hide_icons <+ on_selected
| // === Visualisation Chooser Bindings === | ||
|
|
||
| frp::extend! { network | ||
| selected_definition <- action_bar.visualisation_selection.map(f!([registry](path) |
| @@ -538,7 +552,7 @@ impl Container { | |||
| // === Switching Visualizations === | |||
|
|
|||
| frp::extend! { network | |||
| new_vis_definition <- any(frp.set_visualization,vis_after_cycling,default_visualisation); | |||
| new_vis_definition <- any(frp.set_visualization, selected_definition, vis_after_cycling, default_visualisation).on_change(); | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
The visualization was blank because we set a new visualization instance with same data for attaching, so
VisualizationManagerskipped attaching (and thus the data for previous instance were not shared with the new one).And the entry was visible, because we informed chooser about selected vis before the visualization list arrived.
Fixes #5992 may also fix some other issues with blank visualizations.
Important Notes
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.
./run ide build.