-
Notifications
You must be signed in to change notification settings - Fork 326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Progress Bar For Large Streamed Downloads #6096
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I always wanted it so badly! That's amazing!
@PabloBuchu could I get a QA on this PR please? |
QA 🔴 Everything works fine although I couldn't make the loading bar to appear @indiv0 🤔 |
@PabloBuchu I've fixed the issue you reported on discord RE: the progress bar clobbering logging output. Would you mind QA'ing again? That is, it should no longer do this: |
Nikita Pekin reports a new STANDUP for the provided date (2023-03-31): Progress: Trying to resolve issues with logging not working correctly for large file downloads in build-cli. It should be finished by 2023-04-03. |
@mwu-tow would it be possible to get a QA on this? This touches the build process so it needs to be a cross-platform QA :) (Pawel doesn't have a Windows or Linux machine) |
@indiv0 I will do. |
I did testing on Windows. Some observations:
Minor observations (feel free to leave them for later):
|
|
Pull Request Description
This PR adds a progress bar to streamed downloads.
The build script displays a progress bar when downloading from a remote URL in non-streaming mode. It did not display a progress bar when downloading from a URL in streaming mode. Without a progress bar, large downloads in the build script make it appear as through the build script is stuck.
For example, when running with a remote backend source, the
project-manager-bundle
must be downloaded. This bundle is currently >1GB in size, so it takes several minutes to download. To avoid the appearance of the build script being stuck, we add a progress bar.Screen.Recording.2023-03-28.at.09.59.22.mov
Important Notes
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.
Unit tests have been written where possible.If GUI codebase was changed, the GUI was tested when built using./run ide build
.