Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dedicated Module.containsUUID method with a cache #5945

Merged
merged 4 commits into from
Mar 15, 2023

Conversation

JaroslavTulach
Copy link
Member

@JaroslavTulach JaroslavTulach commented Mar 15, 2023

Pull Request Description

Fixes #5781 by caching all UUIDs in each module in a Map.

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • All code follows the
    Java,
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • All code has been tested:
    • Unit tests continue to work

@JaroslavTulach JaroslavTulach added CI: No changelog needed Do not require a changelog entry for this PR. --low-performance labels Mar 15, 2023
@JaroslavTulach JaroslavTulach added this to the Design Partners milestone Mar 15, 2023
@JaroslavTulach JaroslavTulach self-assigned this Mar 15, 2023
@JaroslavTulach
Copy link
Member Author

I repeated the #5781 scenario with this fix and the UpsertVisualizationJob takes less than 300ms now and the findModuleByExpressionId function wasn't even visible in the sample:

Faster findModuleByExpressionId

@JaroslavTulach JaroslavTulach requested a review from kazcw March 15, 2023 09:38
@JaroslavTulach JaroslavTulach added the CI: Ready to merge This PR is eligible for automatic merge label Mar 15, 2023
@mergify mergify bot merged commit e666d79 into develop Mar 15, 2023
@mergify mergify bot deleted the wip/jtulach/ContainsUUID_5781 branch March 15, 2023 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
--low-performance CI: No changelog needed Do not require a changelog entry for this PR. CI: Ready to merge This PR is eligible for automatic merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UpsertVisualizationJob slowed down by findModuleByExpressionId
2 participants