-
Notifications
You must be signed in to change notification settings - Fork 326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improving Expression Support for In Database #5790
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just a few suggestions.
Btw. does the removal of to_column_name
usages mean that this basically solves #5583 or do we still need to verify something? I guess before we close that one we should add a few 'adversarial' examples that verify that the escaping works correctly, but on the implementation level it seems to be mostly complete?
distribution/lib/Standard/Database/0.0.0-dev/src/Data/Column.enso
Outdated
Show resolved
Hide resolved
distribution/lib/Standard/Database/0.0.0-dev/src/Internal/JDBC_Connection.enso
Outdated
Show resolved
Hide resolved
distribution/lib/Standard/Table/0.0.0-dev/src/Data/Expression.enso
Outdated
Show resolved
Hide resolved
std-bits/database/src/main/java/org/enso/database/JDBCProxy.java
Outdated
Show resolved
Hide resolved
8f77508
to
f8472ea
Compare
Add NULL SQL_Type. Fix return type of arithmetic in DB.
f8472ea
to
a6c3eaa
Compare
Pull Request Description
iif
.to_column_name
andensure_sane_name
code.Checklist
Please include the following checklist in your PR:
Scala,
Java,
and
Rust
style guides.
./run ide build
and./run ide watch
.