Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improving Expression Support for In Database #5790

Merged
merged 13 commits into from
Mar 3, 2023

Conversation

jdunkerley
Copy link
Member

@jdunkerley jdunkerley commented Mar 1, 2023

Pull Request Description

  • Adjust Excel Workbook write behaviour.
  • Support Nothing / Null constants.
  • Deduce the type of arithmetic operations and iif.
  • Allow Date_Time constants, treating as local timezone.
  • Removed the to_column_name and ensure_sane_name code.

Checklist

Please include the following checklist in your PR:

  • The documentation has been updated if necessary.
  • All code conforms to the
    Scala,
    Java,
    and
    Rust
    style guides.
  • All code has been tested:
    • Unit tests have been written where possible.
    • If GUI codebase was changed: Enso GUI was tested when built using BOTH
      ./run ide build and ./run ide watch.

@jdunkerley jdunkerley linked an issue Mar 1, 2023 that may be closed by this pull request
@jdunkerley jdunkerley requested a review from GregoryTravis March 2, 2023 11:10
@jdunkerley jdunkerley added the CI: No changelog needed Do not require a changelog entry for this PR. label Mar 2, 2023
@jdunkerley jdunkerley marked this pull request as ready for review March 2, 2023 11:11
@jdunkerley jdunkerley requested a review from radeusgd as a code owner March 2, 2023 11:11
Copy link
Member

@radeusgd radeusgd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a few suggestions.

Btw. does the removal of to_column_name usages mean that this basically solves #5583 or do we still need to verify something? I guess before we close that one we should add a few 'adversarial' examples that verify that the escaping works correctly, but on the implementation level it seems to be mostly complete?

@jdunkerley jdunkerley force-pushed the wip/jd/5155-fix-expressions-in-database branch from 8f77508 to f8472ea Compare March 2, 2023 17:49
@jdunkerley jdunkerley force-pushed the wip/jd/5155-fix-expressions-in-database branch from f8472ea to a6c3eaa Compare March 3, 2023 10:42
@jdunkerley jdunkerley added the CI: Ready to merge This PR is eligible for automatic merge label Mar 3, 2023
@mergify mergify bot merged commit 01fc34c into develop Mar 3, 2023
@mergify mergify bot deleted the wip/jd/5155-fix-expressions-in-database branch March 3, 2023 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI: No changelog needed Do not require a changelog entry for this PR. CI: Ready to merge This PR is eligible for automatic merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix expressions in Database
3 participants