Don't let the IDE throw away executionContext/executionStatus messages #5734
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JaroslavTulach
requested review from
MichaelMauderer,
wdanilo,
farmaazon and
mwu-tow
as code owners
farmaazon
reviewed
Feb 22, 2023
Comment on lines
+173
to
+177
| /// Any message to be displayed as a notification | ||
| Message { | ||
| /// text of the message | ||
| message: String, | ||
| }, |
There was a problem hiding this comment.
It's not needed, we already have such notifications in
enso/app/gui/src/controller/ide.rs
Line 35 in 20149c1
farmaazon
requested changes
Feb 22, 2023
There was a problem hiding this comment.
I think sometimes this solution can rather confuse user than help him:
- The errors reported in the execution status are still not displayed if warning happens to be first on the list
- We do not inform the user about the place where error is produced. Theoretically it could be in the different file
Overall, I'd prefer to implement #5201 first, then make it properly: display a message with details section, and in details print all the information we get in executionStatus message.
The error log could remain. But then, let's print errors for all messages.
…rowAwayExecutionStatusMessages_5260
|
Original problem addressed by #5794. Closing. |
farmaazon
deleted the
wip/jtulach/DontThrowAwayExecutionStatusMessages_5260
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
IDE currently completely ignores
executionContext/executionStatusmessages without giving user any clue - even if the reported status signals an error.Important Notes
Checklist
Please include the following checklist in your PR:
Rust
style guides.
./run ide buildand./run ide watch.