Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve hash maps #5632

Closed
wants to merge 5 commits into from
Closed

Improve hash maps #5632

wants to merge 5 commits into from

Conversation

Akirathan
Copy link
Member

Pull Request Description

Follow-up PR of #3878.

Important Notes

  • Functions are not comparable.
  • NaNs are not comparable.
  • Refactor Incomparable_Values to a builtin error.
  • Improve API of Map to throw Illegal_Argument for incomparable keys.

Checklist

Please include the following checklist in your PR:

  • The documentation has been updated if necessary.
  • All code conforms to the
    Scala,
    Java,
    and
    Rust
    style guides.
  • All code has been tested:
    • Unit tests have been written where possible.
    • If GUI codebase was changed: Enso GUI was tested when built using BOTH
      ./run ide build and ./run ide watch.

@Akirathan Akirathan linked an issue Feb 10, 2023 that may be closed by this pull request
Get rid of TruffleBoundary in Map.insert and Map.get #5233
Closed
8 tasks
@Akirathan Akirathan self-assigned this Mar 6, 2023
@Akirathan
Copy link
Member Author

Declining as too outdated. There are even no commits that are useful and could be cherry-picked now.

@Akirathan Akirathan closed this Apr 18, 2023
@Akirathan Akirathan deleted the wip/akirathan/hashmap-follow-up-5233 branch December 21, 2023 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdunkerley jdunkerley Awaiting requested review from jdunkerley jdunkerley will be requested when the pull request is marked ready for review jdunkerley is a code owner

@radeusgd radeusgd Awaiting requested review from radeusgd radeusgd will be requested when the pull request is marked ready for review radeusgd is a code owner

@GregoryTravis GregoryTravis Awaiting requested review from GregoryTravis GregoryTravis will be requested when the pull request is marked ready for review GregoryTravis is a code owner

@AdRiley AdRiley Awaiting requested review from AdRiley AdRiley will be requested when the pull request is marked ready for review AdRiley is a code owner

@marthasharkey marthasharkey Awaiting requested review from marthasharkey marthasharkey will be requested when the pull request is marked ready for review marthasharkey is a code owner

@4e6 4e6 Awaiting requested review from 4e6 4e6 will be requested when the pull request is marked ready for review 4e6 is a code owner

@JaroslavTulach JaroslavTulach Awaiting requested review from JaroslavTulach JaroslavTulach will be requested when the pull request is marked ready for review JaroslavTulach is a code owner

@hubertp hubertp Awaiting requested review from hubertp hubertp will be requested when the pull request is marked ready for review hubertp is a code owner

Assignees

@Akirathan Akirathan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Get rid of TruffleBoundary in Map.insert and Map.get
1 participant
@Akirathan