Fix minor issues discovered in native-image #12379
Conversation
Bugs have been reported by first users of NI.
hubertp
added
the
CI: No changelog needed
hubertp
requested review from
jdunkerley,
radeusgd,
GregoryTravis,
AdRiley,
marthasharkey,
4e6,
JaroslavTulach and
Akirathan
as code owners
| @@ -131,6 +131,12 @@ final class JobExecutionEngine( | |||
| } | |||
| logger.log(Level.WARNING, sb.toString()) | |||
| runningJob.future.cancel(runningJob.job.mayInterruptIfRunning) | |||
| case _: CancellationException => | |||
There was a problem hiding this comment.
Is this related to native-image?
There was a problem hiding this comment.
Indirectly. @jdunkerley reported it while using NI but I suppose one could get this exception with JVM runner as well.
|
Weird that this has not been picked up by our nightly checks that should run cloud tests. |
Perhaps the nightly tests are somehow still defaulting to running in non-native mode? Maybe we should consider updating them if native is becoming our default. |
There was a problem hiding this comment.
- with Progress API #12163 integrated
- this PR may need to be updated
std-bits/base/src/main/resources/META-INF/native-image/org/enso/base/reflect-config.json
Show resolved
Hide resolved
Having the test would like discover #12379 early. AOT and JVM modes generate the same result therefore it doesn't make sense to duplicate runs.
|
Hubert Plociniczak reports a new STANDUP for today (2025-02-28): Progress: Addressing more NI bugs. Verifying stale type info bug in #12207 which turned out to be a GUI issue. More testing. It should be finished by 2025-02-28. Next Day: Next day I will be working on the #12379 task. Continue investigating NI issues. |
Pull Request Description
Bugs have been reported by first users of NI.
Important Notes