Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "Run all benchmarks" configuration #12332

Merged
merged 1 commit into from
Feb 20, 2025

Conversation

Akirathan
Copy link
Member

@Akirathan Akirathan commented Feb 19, 2025

Follow-up of #12324

Pull Request Description

When an empty text field for input.bench_name is specified, all the benchmarks should be run. This fixes the failure in https://github.com/enso-org/enso/actions/runs/13418873236/job/37486422641

Important Notes

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    TypeScript,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • Unit tests have been written where possible.
  • If meaningful changes were made to logic or tests affecting Enso Cloud integration in the libraries,
    or the Snowflake database integration, a run of the Extra Tests has been scheduled.
    • If applicable, it is suggested to paste a link to a successful run of the Extra Tests.

@Akirathan Akirathan added the CI: No changelog needed Do not require a changelog entry for this PR. label Feb 19, 2025
@Akirathan Akirathan self-assigned this Feb 19, 2025
@Akirathan
Copy link
Member Author

Akirathan commented Feb 19, 2025

Manually scheduling all bench runs in https://github.com/enso-org/enso/actions/runs/13419432458 . If the build succeeds, I will cancel that workflow and merge this PR.

GitHub
Enso Analytics is a self-service data prep and analysis platform designed for data teams. - Benchmark Standard Libraries · a04e020

@Akirathan Akirathan merged commit d7f3364 into develop Feb 20, 2025
28 of 29 checks passed
@Akirathan Akirathan deleted the wip/akirathan/fix-ci-run-single-bench branch February 20, 2025 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI: No changelog needed Do not require a changelog entry for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants