Fix artifact upload in benchmark jobs #12226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove call to deprecated upload_artifact. See #12210
Akirathan
added
CI: No changelog needed
Akirathan
requested review from
jdunkerley,
AdRiley,
hubertp and
Frizi
as code owners
|
|
|
We are ready to merge |
4e6
approved these changes
Feb 4, 2025
| @@ -831,16 +831,28 @@ pub fn extra_nightly_tests() -> Result<Workflow> { | |||
| } | |||
|
|
|||
| pub fn engine_benchmark() -> Result<Workflow> { | |||
| benchmark_workflow("Benchmark Engine", "backend benchmark runtime", Some(4 * 60)) | |||
| let report_path = "engine/runtime-benchmarks/bench-report.xml"; | |||
| benchmark_workflow("Benchmark Engine", "backend benchmark runtime", report_path, Some(4 * 60)) | |||
There was a problem hiding this comment.
4*60 should be a constant. This way it is clear what it means.
| "Benchmark Standard Libraries", | ||
| "backend benchmark enso-jmh", | ||
| report_path, | ||
| Some(4 * 60), |
|
Can we get this in? I need to run benchmarks for #12201 and I'd like to do it today. |
jdunkerley
approved these changes
Feb 4, 2025
|
|
4 tasks
5 tasks
mergify bot
pushed a commit
that referenced
this pull request
Feb 5, 2025
`./bench_download.py` tool stopped working after #12226. Because the artifacts on benchmark workflow runs were renamed. This PR just renames the artifacts (suggested in #12201 (comment)) and also adds some unit tests. In many unit tests, I had to bump the date of the fetched data, because GH seems to delete workflow runs that are older than 2 years. Note that yesterday, [Benchmark Upload](https://github.com/enso-org/enso/actions/workflows/bench-upload.yml) workflow started printing a [warning that there is an unknown artifact name](https://github.com/enso-org/enso/actions/runs/13152367074/job/36701982751#step:6:1116)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up of #12210 - Remove call to deprecated upload_artifact from benchmark jobs
Pull Request Description
Fixes benchmark jobs. Example of a recent failure is at https://github.com/enso-org/enso/actions/runs/13063541131/job/36451661359
Important Notes
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,
TypeScript,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.
or the Snowflake database integration, a run of the Extra Tests has been scheduled.