Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Table and Column test for nothing values #12205

Merged
merged 5 commits into from
Feb 5, 2025

Conversation

AdRiley
Copy link
Member

@AdRiley AdRiley commented Jan 31, 2025

Pull Request Description

The table and column expect tests were not working properly for Nothing values. This MR fixes that.

Important Notes

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    TypeScript,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • Unit tests have been written where possible.
  • If meaningful changes were made to logic or tests affecting Enso Cloud integration in the libraries,
    or the Snowflake database integration, a run of the Extra Tests has been scheduled.
    • If applicable, it is suggested to paste a link to a successful run of the Extra Tests.

@AdRiley AdRiley added the CI: No changelog needed Do not require a changelog entry for this PR. label Jan 31, 2025
@AdRiley AdRiley force-pushed the wip/adr/fix-test-utils-for-nothing-values branch from bb42b14 to dbd83be Compare February 4, 2025 13:10
@AdRiley AdRiley added the CI: Ready to merge This PR is eligible for automatic merge label Feb 5, 2025
@AdRiley AdRiley merged commit cfd8055 into develop Feb 5, 2025
42 of 45 checks passed
@AdRiley AdRiley deleted the wip/adr/fix-test-utils-for-nothing-values branch February 5, 2025 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI: No changelog needed Do not require a changelog entry for this PR. CI: Ready to merge This PR is eligible for automatic merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants