Add-image button in docs panel #12202
Open
+66
−52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kazcw
added
the
CI: No changelog needed
kazcw
requested review from
Frizi,
farmaazon,
vitvakatu,
AdRiley,
PabloBuchu,
indiv0,
somebody1234 and
MrFlashAccount
as code owners
🧪 Storybook is successfully deployed!📊 Dashboard:
|
farmaazon
approved these changes
Jan 31, 2025
Comment on lines
30
to
34
| // List taken from https://developer.mozilla.org/en-US/docs/Web/Media/Formats/Image_types | ||
| 'image/apng': { extension: 'apng' }, | ||
| 'image/avif': { extension: 'avif' }, | ||
| 'image/gif': { extension: 'gif' }, | ||
| 'image/jpeg': { extension: 'jpg' }, | ||
| 'image/png': { extension: 'png' }, | ||
| 'image/svg+xml': { extension: 'svg' }, | ||
| 'image/webp': { extension: 'webp' }, | ||
| 'image/apng': { extensions: ['apng'] }, | ||
| 'image/avif': { extensions: ['avif'] }, | ||
| 'image/gif': { extensions: ['gif'] }, | ||
| 'image/jpeg': { extensions: ['jpg', 'jpeg'] }, |
There was a problem hiding this comment.
Look at the link in the comment: there are more alternatives for jpeg :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Add button to documentation panel for inserting images; opens a file chooser dialog that is restricted to the same image types we allow when pasting.
Gravacao.do.ecra.2025-01-30.as.18.32.06.mov
Fixes #10102.
Important Notes
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,
TypeScript,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.
or the Snowflake database integration, a run of the Extra Tests has been scheduled.