-
Notifications
You must be signed in to change notification settings - Fork 326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor Dialect_Flag #11273
Refactor Dialect_Flag #11273
Conversation
I think this approach is much more readble. I'm inclined to call it something like 'dialect flag' rather than 'property', because 'property' is more vague, and 'dialect flag' indicates clearly that they are set for each dialect. |
distribution/lib/Standard/Database/0.0.0-dev/src/Internal/Postgres/Postgres_Dialect.enso
Outdated
Show resolved
Hide resolved
distribution/lib/Standard/Database/0.0.0-dev/src/Internal/SQLite/SQLite_Dialect.enso
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not 100% convinced, but I have nothing against the change.
52c6555
to
e1f7a63
Compare
I like this approach because it keeps all the flags together. If each flag were a separate method, they might get separated or out of order, which just makes it more tiring to add or change one across all the backends. |
Pull Request Description
This combines 3 different styles of flagging into a new single style.
It replaces:
I haven't replaced them all yet, this adds the framework future MRs will finish the cleanup.
I think in future any test that relies on a flagged behaviour needs to test both sides of that behaviour.
Important Notes
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,
TypeScript,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.