Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Dialect_Flag #11273

Merged
merged 6 commits into from
Oct 14, 2024
Merged

Refactor Dialect_Flag #11273

merged 6 commits into from
Oct 14, 2024

Conversation

AdRiley
Copy link
Member

@AdRiley AdRiley commented Oct 8, 2024

Pull Request Description

This combines 3 different styles of flagging into a new single style.

It replaces:

  • The old Dialect_flags like use_builtin_bankers
  • Test flags like supports_case_sensitive_columns
  • Method flags like supports_separate_nan

I haven't replaced them all yet, this adds the framework future MRs will finish the cleanup.

I think in future any test that relies on a flagged behaviour needs to test both sides of that behaviour.

Important Notes

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    TypeScript,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • Unit tests have been written where possible.

@AdRiley AdRiley added the CI: No changelog needed Do not require a changelog entry for this PR. label Oct 8, 2024
@GregoryTravis
Copy link
Contributor

I think this approach is much more readble. I'm inclined to call it something like 'dialect flag' rather than 'property', because 'property' is more vague, and 'dialect flag' indicates clearly that they are set for each dialect.

Copy link
Member

@radeusgd radeusgd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not 100% convinced, but I have nothing against the change.

@AdRiley AdRiley changed the title Add property flags Refactor Dialect_Flag Oct 10, 2024
@AdRiley AdRiley force-pushed the wip/adr/add-db-propertty-flags branch from 52c6555 to e1f7a63 Compare October 10, 2024 12:34
@AdRiley AdRiley marked this pull request as ready for review October 10, 2024 12:34
@GregoryTravis
Copy link
Contributor

I like this approach because it keeps all the flags together. If each flag were a separate method, they might get separated or out of order, which just makes it more tiring to add or change one across all the backends.

@AdRiley AdRiley merged commit 03369b9 into develop Oct 14, 2024
36 checks passed
@AdRiley AdRiley deleted the wip/adr/add-db-propertty-flags branch October 14, 2024 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI: No changelog needed Do not require a changelog entry for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants