-
Notifications
You must be signed in to change notification settings - Fork 326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Speedup DataflowError.withDefaultTrace #11153
Merged
mergify
merged 12 commits into
develop
from
wip/akirathan/10702-dataflowerr-stack-regression
Oct 24, 2024
Merged
Changes from 4 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
482d93a
DataflowError.withDefaultTrace has BranchProfile as parameter
Akirathan b63021a
Revert "DataflowError.withDefaultTrace has BranchProfile as parameter"
Akirathan 1e58228
Do not use hardcoded string
Akirathan 243847c
Permissions in ExecutionEnvironment is a final record
Akirathan dd25a6f
hasContextEnabled and update exec env are nodes
Akirathan 3020fe8
Remove unnecessary CompilerAssert.
Akirathan 6ccf304
Cache executionEnvironment in the node
Akirathan ee54f74
Move execution context update functionality to WithContextNode
Akirathan d3f4c8c
transfer to interpreter before string concatenation
Akirathan be57ead
FIx UnsupportedSpecializationException
Akirathan a59af0a
Merge branch 'develop' into wip/akirathan/10702-dataflowerr-stack-reg…
Akirathan 07b918e
Merge branch 'develop' into wip/akirathan/10702-dataflowerr-stack-reg…
Akirathan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This helps with the performance. The compiler is most probably not able to determine that
dataflowStacktraceCtx
is actually a constant (reference to a constructor of a builtin type).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That would be surprising. It is a
CompilerAsserts
- e.g. not a directive, but only an assert that something is true. E.g. eitherdataflowStacktraceCtx
is constant or the compilation is going to fail. The fact whether it is constant or not isn't changed by the assert. The fact whether compilation goes or not is influenced by the assert.