Detect outdated launcher #10779
Merged
Detect outdated launcher #10779
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JaroslavTulach
added
the
CI: No changelog needed
hubertp
approved these changes
Aug 8, 2024
|
Looks like the CI is affected by this change: Thanks to that two tests are running in JVM mode instead of NI mode... |
JaroslavTulach
added
the
CI: Ready to merge
JaroslavTulach
commented
Aug 13, 2024
|
|
||
| var assertsOn = false; | ||
| assert assertsOn = true; | ||
| if (assertsOn) { |
There was a problem hiding this comment.
This "transfer of assertion mode" is now causing following failure, @Akirathan:
Execution finished with an error: java.lang.AssertionError
at <java> org.enso.runtime/org.enso.interpreter.runtime.warning.WithWarnings.<init>(WithWarnings.java:82)
at <java> org.enso.runtime/org.enso.interpreter.runtime.warning.AppendWarningNode.doObjectMultipleWarningsHashMap(AppendWarningNode.java:120)
at <java> org.enso.runtime/org.enso.interpreter.runtime.warning.AppendWarningNodeGen.executeAndSpecialize(AppendWarningNodeGen.java:318)
at <java> org.enso.runtime/org.enso.interpreter.runtime.warning.AppendWarningNodeGen.executeAppend(AppendWarningNodeGen.java:193)
at <java> org.enso.runtime/org.enso.interpreter.runtime.data.atom.InstantiateNode.doExecute(InstantiateNode.java:102)
at <java> org.enso.runtime/org.enso.interpreter.runtime.data.atom.InstantiateNodeGen.executeAndSpecialize(InstantiateNodeGen.java:95)
at <java> org.enso.runtime/org.enso.interpreter.runtime.data.atom.InstantiateNodeGen.executeGeneric(InstantiateNodeGen.java:76)
at <java> org.enso.runtime/org.enso.interpreter.node.callable.function.BlockNode.executeGeneric(BlockNode.java:54)
at <java> org.enso.runtime/org.enso.interpreter.node.ClosureRootNode.execute(ClosureRootNode.java:85)
at <enso> Data.Value(Internal)
at <enso> Data.type.new(src/Decimal_Benchmark.enso:30:9-180)
at <enso> Decimal_Benchmark.collect_benches.Decimal_Benchmark.collect_benches<arg-1>(src/Decimal_Benchmark.enso:37:29-42)
the 5575d88 change should fix the problem.
There was a problem hiding this comment.
Alas, that fix leads to this error:
️ Execution finished with an error: java.lang.AssertionError
️at <java> org.enso.interpreter.runtime.warning.WithWarnings.<init>(WithWarnings.java:84)
️at <java> org.enso.interpreter.runtime.warning.AppendWarningNode.doWithWarnMultipleWarningsHashMap(AppendWarningNode.java:140)
at <java> org.enso.interpreter.runtime.warning.AppendWarningNodeGen.executeAndSpecialize(AppendWarningNodeGen.java:345)
at <java> org.enso.interpreter.runtime.warning.AppendWarningNodeGen.executeAppend(AppendWarningNodeGen.java:193)
at <java> org.enso.interpreter.node.callable.InvokeMethodNode.doWarning(InvokeMethodNode.java:479)
️at <java> org.enso.interpreter.node.callable.InvokeMethodNodeGen.executeAndSpecialize(InvokeMethodNodeGen.java:781)
️at <java> org.enso.interpreter.node.callable.InvokeMethodNodeGen.execute(InvokeMethodNodeGen.java:533)
let's assume 0b9a49b fixes both - the instantiate and the invoke case.
Akirathan
reviewed
Aug 13, 2024
|
Jaroslav Tulach reports a new STANDUP for yesterday (2024-08-13): Progress: - Fixing
|
JaroslavTulach
removed
the
CI: Ready to merge
|
Jaroslav Tulach reports a new STANDUP for yesterday (2024-08-14): Progress: - merging and adjusting to comments: #10779 (comment)
|
JaroslavTulach
force-pushed
the
wip/jtulach/DetectOutdatedLauncher
branch
from
0ce6d9f to
0b9a49b
Compare
Akirathan
approved these changes
Aug 15, 2024
|
Jaroslav Tulach reports a new STANDUP for yesterday (2024-08-15): Progress: - failure with max warnings limit: 0ce6d9f
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
When any of the JARs is older than the main executable, print a warning and switch to JVM mode.
Important Notes
The
baseis obtained bygetCodeSource().getLocation(). In case of JVM mode, it is a JAR - e.g. not executable file. In case of native image launcher, it is the executable file - e.g.base.canExecute()returns true. As such the check is only performed in native image launcher.Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Java,