Mixed Decimal/Float operations throw error or attach warning

CHANGELOG.md

@@ -6,9 +6,12 @@
   comparisons.][10614]
 - [Relative paths are now resolved relative to the project location, also in the
   Cloud.][10660]
+- [Mixed Decimal/Float arithmetic now throws an error; mixed comparisons now
+  attach warnings.][10725]
 
 [10614]: https://github.com/enso-org/enso/pull/10614
 [10660]: https://github.com/enso-org/enso/pull/10660
+[10725]: https://github.com/enso-org/enso/pull/10725
 
 # Enso 2023.3
 

distribution/lib/Standard/Base/0.0.0-dev/src/Data/Numeric/Internal/Decimal_Internal.enso

@@ -3,6 +3,8 @@ private
 import project.Data.Decimal.Decimal
 import project.Data.Numbers.Number
 import project.Data.Text.Text
+from project.Errors.Common import Loss_Of_Numeric_Precision
+import project.Warning.Warning
 from project.Data.Ordering import Comparable, Ordering
 
 polyglot java import org.enso.base.numeric.Decimal_Utils
@@ -11,4 +13,5 @@ polyglot java import org.enso.base.numeric.Decimal_Utils
 type Decimal_Comparator
     compare (x : Decimal) (y : Decimal) =
         Ordering.from_sign (x.big_decimal.compareTo y.big_decimal)
+
     hash x:Decimal = Decimal_Utils.hashCodeOf x.big_decimal

distribution/lib/Standard/Table/0.0.0-dev/src/Internal/Storage.enso

@@ -2,6 +2,7 @@ from Standard.Base import all
 import Standard.Base.Errors.Common.Index_Out_Of_Bounds
 import Standard.Base.Errors.Illegal_Argument.Illegal_Argument
 import Standard.Base.Errors.Illegal_State.Illegal_State
+from Standard.Base.Data.Decimal import from_big_decimal, get_big_decimal
 
 import project.Column.Column
 import project.Value_Type.Bits
@@ -78,7 +79,7 @@ closest_storage_type value_type = case value_type of
    This step is unnecessary for primitive and builtin values, but necessary for
    values such as `Decimal`/`BigDecimal`.
 enso_to_java x = case x of
-    Decimal.Value big_decimal -> big_decimal
+    _ : Decimal -> get_big_decimal x
     _ -> x
 
 ## PRIVATE
@@ -88,7 +89,7 @@ enso_to_java x = case x of
    necessary for values such as `Decimal`/`BigDecimal`.
 java_to_enso x = case x of
     _ : Nothing -> Nothing
-    _ : BigDecimal -> Decimal.Value x
+    _ : BigDecimal -> from_big_decimal x
     _ -> x
 
 ## PRIVATE

engine/runtime/src/main/java/org/enso/interpreter/node/expression/builtin/meta/EqualsAtomNode.java

@@ -9,6 +9,7 @@
 import com.oracle.truffle.api.dsl.Specialization;
 import com.oracle.truffle.api.frame.MaterializedFrame;
 import com.oracle.truffle.api.frame.VirtualFrame;
+import com.oracle.truffle.api.interop.UnsupportedMessageException;
 import com.oracle.truffle.api.library.CachedLibrary;
 import com.oracle.truffle.api.nodes.ExplodeLoop;
 import com.oracle.truffle.api.nodes.Node;
@@ -25,6 +26,7 @@
 import org.enso.interpreter.runtime.data.atom.Atom;
 import org.enso.interpreter.runtime.data.atom.AtomConstructor;
 import org.enso.interpreter.runtime.data.atom.StructsLibrary;
+import org.enso.interpreter.runtime.error.WarningsLibrary;
 import org.enso.interpreter.runtime.library.dispatch.TypeOfNode;
 import org.enso.interpreter.runtime.state.State;
 
@@ -91,16 +93,24 @@ boolean equalsAtomsWithCustomComparator(
       @Cached(value = "customComparatorNode.execute(self)") Type cachedComparator,
       @Cached(value = "findCompareMethod(cachedComparator)", allowUncached = true)
           Function compareFn,
-      @Cached(value = "invokeCompareNode(compareFn)") InvokeFunctionNode invokeNode) {
-    var otherComparator = customComparatorNode.execute(other);
-    if (cachedComparator != otherComparator) {
-      return false;
+      @Cached(value = "invokeCompareNode(compareFn)") InvokeFunctionNode invokeNode,
+      @Shared @CachedLibrary(limit = "10") WarningsLibrary warnings) {
+    try {
+      var otherComparator = customComparatorNode.execute(other);
+      if (cachedComparator != otherComparator) {
+        return false;
+      }
+      var ctx = EnsoContext.get(this);
+      var args = new Object[] {cachedComparator, self, other};
+      var result = invokeNode.execute(compareFn, null, State.create(ctx), args);
+      assert orderingOrNullOrError(this, ctx, result, compareFn);
+      if (warnings.hasWarnings(result)) {
+        result = warnings.removeWarnings(result);
+      }
+      return ctx.getBuiltins().ordering().newEqual() == result;
+    } catch (UnsupportedMessageException e) {
+      throw EnsoContext.get(this).raiseAssertionPanic(this, null, e);
     }
-    var ctx = EnsoContext.get(this);
-    var args = new Object[] {cachedComparator, self, other};
-    var result = invokeNode.execute(compareFn, null, State.create(ctx), args);
-    assert orderingOrNullOrError(this, ctx, result, compareFn);
-    return ctx.getBuiltins().ordering().newEqual() == result;
   }
 
   @TruffleBoundary
@@ -123,16 +133,21 @@ private static boolean orderingOrNullOrError(
 
   @Specialization(
       replaces = {"equalsAtomsWithDefaultComparator", "equalsAtomsWithCustomComparator"})
-  boolean equalsAtomsUncached(VirtualFrame frame, Atom self, Atom other) {
+  boolean equalsAtomsUncached(
+      VirtualFrame frame,
+      Atom self,
+      Atom other,
+      @Shared @CachedLibrary(limit = "10") WarningsLibrary warnings) {
     if (self.getConstructor() != other.getConstructor()) {
       return false;
     } else {
-      return equalsAtomsUncached(frame == null ? null : frame.materialize(), self, other);
+      return equalsAtomsUncached(frame == null ? null : frame.materialize(), self, other, warnings);
     }
   }
 
   @CompilerDirectives.TruffleBoundary
-  private boolean equalsAtomsUncached(MaterializedFrame frame, Atom self, Atom other) {
+  private boolean equalsAtomsUncached(
+      MaterializedFrame frame, Atom self, Atom other, WarningsLibrary warnings) {
     Type customComparator = CustomComparatorNode.getUncached().execute(self);
     if (customComparator != null) {
       Function compareFunc = findCompareMethod(customComparator);
@@ -144,7 +159,8 @@ private boolean equalsAtomsUncached(MaterializedFrame frame, Atom self, Atom oth
           CustomComparatorNode.getUncached(),
           customComparator,
           compareFunc,
-          invokeFuncNode);
+          invokeFuncNode,
+          warnings);
     }
     for (int i = 0; i < self.getConstructor().getArity(); i++) {
       var selfField = StructsLibrary.getUncached().getField(self, i);