Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Upload_Table to be more readable: split into separate smaller submodules #10713

Merged
merged 4 commits into from
Jul 31, 2024

Conversation

radeusgd
Copy link
Member

@radeusgd radeusgd commented Jul 29, 2024

Pull Request Description

  • First step of Implement transactional Table Upload / Update / Delete Rows for Snowflake backend #10609 - before I actually modify it, I decided I need to refactor the Upload_Table logic as it was quite convoluted. Doing this as a separate PR for easier review. A big 600+ line file was replaced by several smaller ones grouped by topics.
  • Practically no changes apart from moving stuff into separate modules.
  • One small change - added Missing_Argument to SQL_Query as I noticed that lack of defaults was giving rise to confusing errors when working with query in the GUI.

Before:
image
After:
image
image

Important Notes

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    TypeScript,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • Unit tests have been written where possible.

@radeusgd radeusgd added the CI: No changelog needed Do not require a changelog entry for this PR. label Jul 29, 2024
@radeusgd radeusgd self-assigned this Jul 29, 2024
@radeusgd radeusgd force-pushed the wip/radeusgd/refactor-upload-table branch from 9fb17f2 to 7c8b7cd Compare July 30, 2024 10:41
@radeusgd radeusgd added the CI: Ready to merge This PR is eligible for automatic merge label Jul 31, 2024
@mergify mergify bot merged commit 6ad3faf into develop Jul 31, 2024
37 checks passed
@mergify mergify bot deleted the wip/radeusgd/refactor-upload-table branch July 31, 2024 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI: No changelog needed Do not require a changelog entry for this PR. CI: Ready to merge This PR is eligible for automatic merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants