Date_Time_Spec test failure `Zone offset not in valid range` #7655

GregoryTravis · 2023-08-24T15:47:23Z

Getting this error running Date_Time_Spec on develop:

Execution finished with an error: java.time.DateTimeException: Zone offset not in valid range: -18:00 to +18:00
        at <java> java.base/java.time.ZoneOffset.ofTotalSeconds(ZoneOffset.java:417)
        at <java> com.oracle.graal.python.builtins.objects.PythonAbstractObject.createZoneId(PythonAbstractObject.java:1001)
        at <java> com.oracle.graal.python.builtins.objects.PythonAbstractObject.asTimeZone(PythonAbstractObject.java:949)

The text was updated successfully, but these errors were encountered:

GregoryTravis · 2023-08-25T15:40:03Z

This is happening for me only in the Python tests.

JaroslavTulach · 2023-08-26T07:32:25Z

I assume you have America/New Your time zone. Can you share longer stacktrace that would show a code in our codebase to put breakpoint to? Can you add Enso stacktrace as well?

This is happening for me only in the Python tests.

Obviously when com.oracle.graal.python.builtins.objects.PythonAbstractObject is a class from Graal Python project ;-)

GregoryTravis · 2023-08-30T13:43:51Z

Full stack trace:

Execution finished with an error: java.time.DateTimeException: Zone offset not in valid range: -18:00 to +18:00
        at <java> java.base/java.time.ZoneOffset.ofTotalSeconds(ZoneOffset.java:417)
        at <java> com.oracle.graal.python.builtins.objects.PythonAbstractObject.createZoneId(PythonAbstractObject.java:1001)
        at <java> com.oracle.graal.python.builtins.objects.PythonAbstractObject.asTimeZone(PythonAbstractObject.java:949)
        at <java> com.oracle.graal.python.builtins.objects.PythonAbstractObjectGen$InteropLibraryExports$Cached.asTimeZoneNode_AndSpecialize(PythonAbstractObjectGen.java:2965)
        at <java> com.oracle.graal.python.builtins.objects.PythonAbstractObjectGen$InteropLibraryExports$Cached.asTimeZone(PythonAbstractObjectGen.java:2855)
        at <java> org.graalvm.truffle/com.oracle.truffle.api.interop.InteropLibraryGen$CachedDispatch.asTimeZone(InteropLibraryGen.java:9304)
        at <java> org.enso.interpreter.node.callable.InvokeMethodNode.doConvertZonedDateTime(InvokeMethodNode.java:723)
        at <java> org.enso.interpreter.node.callable.InvokeMethodNodeGen.executeAndSpecialize(InvokeMethodNodeGen.java:1430)
        at <java> org.enso.interpreter.node.callable.InvokeMethodNodeGen.execute(InvokeMethodNodeGen.java:506)
        at <java> org.enso.interpreter.node.callable.InvokeCallableNode.invokeDynamicSymbol(InvokeCallableNode.java:254)
        at <java> org.enso.interpreter.node.callable.InvokeCallableNodeGen.execute(InvokeCallableNodeGen.java:137)
        at <java> org.enso.interpreter.node.callable.ApplicationNode.executeGeneric(ApplicationNode.java:96)
        at <java> org.enso.interpreter.node.ClosureRootNode.execute(ClosureRootNode.java:85)
        at <enso> Date_Time_Spec.spec_with<arg-0>(Internal)
        at <enso> Date_Time_Spec.spec_with<arg-1>(Date_Time_Spec.enso:111:13-43)
        at <enso> Test.run_spec<arg-1>(/Users/gmt/dev/enso/enso/built-distribution/enso-engine-0.0.0-dev-macos-amd64/enso-0.0.0-dev/lib/Standard/Test/0.0.0-dev/src/Test.enso:200:18-25)
        at <enso> Panic.catch(Internal)
        at <enso> Panic.type.recover(/Users/gmt/dev/enso/enso/built-distribution/enso-engine-0.0.0-dev-macos-amd64/enso-0.0.0-dev/lib/Standard/Base/0.0.0-dev/src/Panic.enso:185-190)
        at <enso> Test.run_spec(/Users/gmt/dev/enso/enso/built-distribution/enso-engine-0.0.0-dev-macos-amd64/enso-0.0.0-dev/lib/Standard/Test/0.0.0-dev/src/Test.enso:199-203)
        at <enso> case_branch<arg-3>(/Users/gmt/dev/enso/enso/built-distribution/enso-engine-0.0.0-dev-macos-amd64/enso-0.0.0-dev/lib/Standard/Test/0.0.0-dev/src/Test.enso:77:73-89)
        at <enso> case_branch<arg-1>(/Users/gmt/dev/enso/enso/built-distribution/enso-engine-0.0.0-dev-macos-amd64/enso-0.0.0-dev/lib/Standard/Test/0.0.0-dev/src/Test.enso:77:49-90)
        at <enso> Runtime.no_inline(Internal)
        at <enso> Duration.type.time_execution(/Users/gmt/dev/enso/enso/built-distribution/enso-engine-0.0.0-dev-macos-amd64/enso-0.0.0-dev/lib/Standard/Base/0.0.0-dev/src/Data/Time/Duration.enso:127:18-43)
        at <enso> case_branch(/Users/gmt/dev/enso/enso/built-distribution/enso-engine-0.0.0-dev-macos-amd64/enso-0.0.0-dev/lib/Standard/Test/0.0.0-dev/src/Test.enso:77:24-91)
        at <enso> Test.specify(/Users/gmt/dev/enso/enso/built-distribution/enso-engine-0.0.0-dev-macos-amd64/enso-0.0.0-dev/lib/Standard/Test/0.0.0-dev/src/Test.enso:76-78)
        at <enso> Date_Time_Spec.spec_with<arg-1>(Date_Time_Spec.enso:109-118)
        at <enso> case_branch<arg-1>(/Users/gmt/dev/enso/enso/built-distribution/enso-engine-0.0.0-dev-macos-amd64/enso-0.0.0-dev/lib/Standard/Test/0.0.0-dev/src/Test.enso:40:29-37)
        at <enso> case_branch<arg-1>(/Users/gmt/dev/enso/enso/built-distribution/enso-engine-0.0.0-dev-macos-amd64/enso-0.0.0-dev/lib/Standard/Test/0.0.0-dev/src/Test.enso:39-41)
        at <enso> Panic.catch(Internal)
        at <enso> case_branch(/Users/gmt/dev/enso/enso/built-distribution/enso-engine-0.0.0-dev-macos-amd64/enso-0.0.0-dev/lib/Standard/Test/0.0.0-dev/src/Test.enso:38-41)
        at <enso> Test.group<arg-1>(/Users/gmt/dev/enso/enso/built-distribution/enso-engine-0.0.0-dev-macos-amd64/enso-0.0.0-dev/lib/Standard/Test/0.0.0-dev/src/Test.enso:31-46)
        at <enso> Test.group(/Users/gmt/dev/enso/enso/built-distribution/enso-engine-0.0.0-dev-macos-amd64/enso-0.0.0-dev/lib/Standard/Test/0.0.0-dev/src/Test.enso:30-46)
        at <enso> Date_Time_Spec.spec_with(Date_Time_Spec.enso:55-858)
        at <enso> Date_Time_Spec.spec<arg-1>(Date_Time_Spec.enso:27:9-126)
        at <enso> Date_Time_Spec.spec(Date_Time_Spec.enso:23-27)
        at <enso> Date_Time_Spec.main<arg-1>(Date_Time_Spec.enso:939:28-31)
        at <enso> Test_Suite.type.run<arg-1>(/Users/gmt/dev/enso/enso/built-distribution/enso-engine-0.0.0-dev-macos-amd64/enso-0.0.0-dev/lib/Standard/Test/0.0.0-dev/src/Test_Suite.enso:69:17-21)
        at <enso> Test_Suite.type.run<arg-1>(/Users/gmt/dev/enso/enso/built-distribution/enso-engine-0.0.0-dev-macos-amd64/enso-0.0.0-dev/lib/Standard/Test/0.0.0-dev/src/Test_Suite.enso:68-70)
        at <enso> Test_Reporter.wrap_junit_testsuites(/Users/gmt/dev/enso/enso/built-distribution/enso-engine-0.0.0-dev-macos-amd64/enso-0.0.0-dev/lib/Standard/Test/0.0.0-dev/src/Test_Reporter.enso:18:14-19)
        at <enso> Test_Suite.type.run(/Users/gmt/dev/enso/enso/built-distribution/enso-engine-0.0.0-dev-macos-amd64/enso-0.0.0-dev/lib/Standard/Test/0.0.0-dev/src/Test_Suite.enso:67-70)
        at <enso> Test_Suite.type.run_main(/Users/gmt/dev/enso/enso/built-distribution/enso-engine-0.0.0-dev-macos-amd64/enso-0.0.0-dev/lib/Standard/Test/0.0.0-dev/src/Test_Suite.enso:40:13-39)
        at <enso> Date_Time_Spec.main(Date_Time_Spec.enso:939:8-31)

GregoryTravis · 2023-08-30T13:44:21Z

There is no enso stack trace. Full output:

out.txt

JaroslavTulach · 2023-08-30T14:33:08Z

@GregoryTravis please try to "debug out" some more info. For example: Can you print out the time and its zone just before the error? Something like:

enso$ git diff test
diff --git test/Tests/src/Data/Time/Date_Time_Spec.enso test/Tests/src/Data/Time/Date_Time_Spec.enso
index dc61e3b8e4..50daf3689c 100644
--- test/Tests/src/Data/Time/Date_Time_Spec.enso
+++ test/Tests/src/Data/Time/Date_Time_Spec.enso
@@ -108,6 +108,8 @@ spec_with name create_new_datetime parse_datetime nanoseconds_loss_in_precision=
 
         Test.specify "should parse local time adding system zone" <|
             time = parse_datetime "1970-01-01T00:00:01"
+            IO.println <| Objects.toString time
+            IO.println <| Objects.toString time.zone
             time . year . should_equal 1970
             time . month . should_equal 1
             time . day . should_equal 1

JaroslavTulach · 2023-08-30T15:54:22Z

The printed time:

datetime.datetime(1970, 1, 1, 0, 0, 1, tzinfo=<__main__.EnsoTzInfo object at 0x3f90f77a>)

JaroslavTulach · 2023-10-11T15:29:55Z

I can reprodue the problem relatively easily:

diff --git test/Tests/src/Data/Time/Date_Time_Spec.enso test/Tests/src/Data/Time/Date_Time_Spec.enso
index 613ff1b1d8..a9d0f24094 100644
--- test/Tests/src/Data/Time/Date_Time_Spec.enso
+++ test/Tests/src/Data/Time/Date_Time_Spec.enso
@@ -134,6 +134,16 @@ spec_with name create_new_datetime parse_datetime nanoseconds_loss_in_precision=
             dt1.zone . zone_id . should_equal interop_tz.zone_id
             dt1.to_display_text . should_equal "2020-01-01 01:00:00 +01:00"
 
+        Test.specify "epoch in New York" <|
+            tz = Time_Zone.parse "America/New_York"
+            time = create_new_datetime zone=tz 1970 1 1 0 0 1
+            time . hour . should_equal 0
+            time . minute . should_equal 0
+            time . second . should_equal 1
+            time . millisecond . should_equal 0
+            time . microsecond . should_equal 0
+            time . nanosecond . should_equal 0
+
         Test.specify "should get time of day from offsed-based time" <|
             time = parse_datetime "1970-01-01T00:00:01+01:00" . time_of_day
             time . hour . should_equal 0

the problem however cannot be fixed on our side. It requires changes to GraalPy: submitted as https://github.com/oracle/graalpython/pull/360/files

jdunkerley · 2023-12-12T09:47:47Z

To be tested against the GraalVM fixes they have delivered.

JaroslavTulach · 2024-05-30T14:26:45Z

Fixed by some upgrade of GraalVM that brought in oracle/graalpython#360

github-project-automation bot added this to Issues Board Aug 24, 2023

github-project-automation bot moved this to ❓New in Issues Board Aug 24, 2023

GregoryTravis mentioned this issue Aug 24, 2023

fix dst test failure #7649

Merged

5 tasks

hubertp added the -libs Libraries: New libraries to be implemented label Aug 25, 2023

GregoryTravis assigned JaroslavTulach Aug 25, 2023

GregoryTravis added the p-medium Should be completed in the next few sprints label Aug 25, 2023

jdunkerley moved this from ❓New to 📤 Backlog in Issues Board Aug 29, 2023

JaroslavTulach mentioned this issue Oct 11, 2023

Don't ignore days in timedelta when converting to TimeZone oracle/graalpython#360

Merged

enso-bot bot mentioned this issue Oct 12, 2023

Polyglot classes ignored in the type check signature #7858

Closed

jdunkerley added the x-on-hold label Oct 17, 2023

jdunkerley removed the x-on-hold label Dec 12, 2023

JaroslavTulach mentioned this issue Dec 14, 2023

Run Enso tests with assertions enabled #7882

Merged

2 tasks

jdunkerley added the x-on-hold label Jan 9, 2024

JaroslavTulach added a commit that referenced this issue May 30, 2024

Test that verifies #7655 is fixed

ab9e3e5

JaroslavTulach mentioned this issue May 30, 2024

Give qualified name of type a location #10138

Merged

2 tasks

JaroslavTulach closed this as completed May 30, 2024

github-project-automation bot moved this from 📤 Backlog to 🟢 Accepted in Issues Board May 30, 2024

enso-bot bot mentioned this issue May 31, 2024

State is not propagated to lazy field evaluation #7571

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Date_Time_Spec test failure `Zone offset not in valid range` #7655

Date_Time_Spec test failure `Zone offset not in valid range` #7655

GregoryTravis commented Aug 24, 2023

GregoryTravis commented Aug 25, 2023

JaroslavTulach commented Aug 26, 2023 •

edited

Loading

GregoryTravis commented Aug 30, 2023

GregoryTravis commented Aug 30, 2023

JaroslavTulach commented Aug 30, 2023

JaroslavTulach commented Aug 30, 2023

JaroslavTulach commented Oct 11, 2023 •

edited

Loading

jdunkerley commented Dec 12, 2023

JaroslavTulach commented May 30, 2024

Date_Time_Spec test failure Zone offset not in valid range #7655

Date_Time_Spec test failure Zone offset not in valid range #7655

Comments

GregoryTravis commented Aug 24, 2023

GregoryTravis commented Aug 25, 2023

JaroslavTulach commented Aug 26, 2023 • edited Loading

GregoryTravis commented Aug 30, 2023

GregoryTravis commented Aug 30, 2023

JaroslavTulach commented Aug 30, 2023

JaroslavTulach commented Aug 30, 2023

JaroslavTulach commented Oct 11, 2023 • edited Loading

jdunkerley commented Dec 12, 2023

JaroslavTulach commented May 30, 2024

Date_Time_Spec test failure `Zone offset not in valid range` #7655

Date_Time_Spec test failure `Zone offset not in valid range` #7655

JaroslavTulach commented Aug 26, 2023 •

edited

Loading

JaroslavTulach commented Oct 11, 2023 •

edited

Loading