Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rounding functions to the In-Database Column type #6886

Closed
jdunkerley opened this issue May 30, 2023 · 34 comments · Fixed by #6988
Closed

Add rounding functions to the In-Database Column type #6886

jdunkerley opened this issue May 30, 2023 · 34 comments · Fixed by #6988
Assignees
Labels
-libs Libraries: New libraries to be implemented x-new-feature Type: new feature request
Milestone

Comments

@jdunkerley
Copy link
Member

jdunkerley commented May 30, 2023

Add ceil, floor, truncate and round to the Database.

@jdunkerley jdunkerley converted this from a draft issue May 30, 2023
@jdunkerley jdunkerley added this to the Beta Release milestone May 30, 2023
@jdunkerley jdunkerley added x-new-feature Type: new feature request -libs Libraries: New libraries to be implemented labels May 30, 2023
@GregoryTravis GregoryTravis moved this from 📤 Backlog to 🔧 Implementation in Issues Board Jun 6, 2023
@enso-bot
Copy link

enso-bot bot commented Jun 6, 2023

Greg Travis reports a new STANDUP for today (2023-06-06):

Progress: learning about dialects It should be finished by 2023-06-12.

Next Day: more

@enso-bot
Copy link

enso-bot bot commented Jun 7, 2023

Greg Travis reports a new STANDUP for today (2023-06-07):

Progress: Study Dialect implementation, propose and discuss plan for .truncate with Radek; implement truncate and one test; setup for postgres testing; separate pg+sl trunc implementations It should be finished by 2023-06-12.

Next Day: more

@enso-bot
Copy link

enso-bot bot commented Jun 8, 2023

Greg Travis reports a new STANDUP for today (2023-06-08):

Progress: db trunc, ceil, floor; made the sqlite parser stack overflow; converting rounding code to sql It should be finished by 2023-06-12.

Next Day: more

@enso-bot
Copy link

enso-bot bot commented Jun 9, 2023

Greg Travis reports a new STANDUP for today (2023-06-09):

Progress: discussion with James; reimplement rounding as column arithmetic It should be finished by 2023-06-12.

Next Day: full rounding tests

@enso-bot
Copy link

enso-bot bot commented Jun 12, 2023

Greg Travis reports a new STANDUP for today (2023-06-12):

Progress: rounding tests; edge cases; sqlite/pg differences It should be finished by 2023-06-12.

Next Day: more tests

@enso-bot
Copy link

enso-bot bot commented Jun 13, 2023

Greg Travis reports a new 🔴 DELAY for today (2023-06-13):

Summary: There is 1 days delay in implementation of the Add rounding functions to the In-Database Column type (#6886) task.
It will cause 0 days delay for the delivery of this weekly plan.

Delay Cause: lots of cases

@enso-bot
Copy link

enso-bot bot commented Jun 13, 2023

Greg Travis reports a new STANDUP for today (2023-06-13):

Progress: Fixing up const columns and adding tests; make trunc, floor, ceil generic; tests tests tests; sent generic pr It should be finished by 2023-06-13.

Next Day: specializations

@enso-bot
Copy link

enso-bot bot commented Jun 14, 2023

Greg Travis reports a new 🔴 DELAY for today (2023-06-14):

Summary: There is 1 days delay in implementation of the Add rounding functions to the In-Database Column type (#6886) task.
It will cause 0 days delay for the delivery of this weekly plan.

Delay Cause: review

@enso-bot
Copy link

enso-bot bot commented Jun 14, 2023

Greg Travis reports a new STANDUP for today (2023-06-14):

Progress: Review; try + fail to reimplement not as an operator It should be finished by 2023-06-14.

Next Day: specializations

@enso-bot
Copy link

enso-bot bot commented Jun 15, 2023

Greg Travis reports a new 🔴 DELAY for today (2023-06-15):

Summary: There is 1 days delay in implementation of the Add rounding functions to the In-Database Column type (#6886) task.
It will cause 0 days delay for the delivery of this weekly plan.

Delay Cause: review

@enso-bot
Copy link

enso-bot bot commented Jun 15, 2023

Greg Travis reports a new STANDUP for today (2023-06-15):

Progress: column arithmetic for in-mem too; only test decimal on pg-like; factor out dp check; in-memory constant columns; share implementation with evaluate_expression and get rid of op It should be finished by 2023-06-15.

Next Day: specializations

@enso-bot
Copy link

enso-bot bot commented Jun 16, 2023

Greg Travis reports a new 🔴 DELAY for today (2023-06-16):

Summary: There is 1 days delay in implementation of the Add rounding functions to the In-Database Column type (#6886) task.
It will cause 0 days delay for the delivery of this weekly plan.

Delay Cause: it just never ends

@enso-bot
Copy link

enso-bot bot commented Jun 16, 2023

Greg Travis reports a new STANDUP for today (2023-06-16):

Progress: Symmetric rounding for all three; Integer rounding for db; parity between different implementations It should be finished by 2023-06-16.

Next Day: specializations

@enso-bot
Copy link

enso-bot bot commented Jun 19, 2023

Greg Travis reports a new 🔴 DELAY for today (2023-06-19):

Summary: There is 3 days delay in implementation of the Add rounding functions to the In-Database Column type (#6886) task.
It will cause 0 days delay for the delivery of this weekly plan.

Delay Cause: review

@enso-bot
Copy link

enso-bot bot commented Jun 19, 2023

Greg Travis reports a new STANDUP for today (2023-06-19):

Progress: review; integer-only rounding; return types; mysterious missing Clue error It should be finished by 2023-06-19.

Next Day: specializations

@enso-bot
Copy link

enso-bot bot commented Jun 20, 2023

Greg Travis reports a new 🔴 DELAY for today (2023-06-20):

Summary: There is 1 days delay in implementation of the Add rounding functions to the In-Database Column type (#6886) task.
It will cause 0 days delay for the delivery of this weekly plan.

Delay Cause: in-mem parity

@enso-bot
Copy link

enso-bot bot commented Jun 20, 2023

Greg Travis reports a new STANDUP for today (2023-06-20):

Progress: Correct return types: pg, sl, in-mem; Clue bug; mixed column issue with column arithmetic It should be finished by 2023-06-20.

Next Day: specializations

@enso-bot
Copy link

enso-bot bot commented Jun 21, 2023

Greg Travis reports a new 🔴 DELAY for today (2023-06-21):

Summary: There is 1 days delay in implementation of the Add rounding functions to the In-Database Column type (#6886) task.
It will cause 0 days delay for the delivery of this weekly plan.

Delay Cause: postgres round losing precision

@enso-bot
Copy link

enso-bot bot commented Jun 21, 2023

Greg Travis reports a new STANDUP for today (2023-06-21):

Progress: input check for in-mem round; use make_function; why is postgres round losing precision? It should be finished by 2023-06-21.

Next Day: specializations

@enso-bot
Copy link

enso-bot bot commented Jun 22, 2023

Greg Travis reports a new 🔴 DELAY for today (2023-06-22):

Summary: There is 1 days delay in implementation of the Add rounding functions to the In-Database Column type (#6886) task.
It will cause 0 days delay for the delivery of this weekly plan.

Delay Cause: postgres+sqlite idiosyncrasies

@enso-bot
Copy link

enso-bot bot commented Jun 22, 2023

Greg Travis reports a new STANDUP for today (2023-06-22):

Progress: return types; postgres decimal special case; sqlite integer bit size It should be finished by 2023-06-22.

Next Day: specializations (sigh)

@enso-bot
Copy link

enso-bot bot commented Jun 23, 2023

Greg Travis reports a new 🔴 DELAY for today (2023-06-23):

Summary: There is 1 days delay in implementation of the Add rounding functions to the In-Database Column type (#6886) task.
It will cause 0 days delay for the delivery of this weekly plan.

Delay Cause: nan/inf handling

@enso-bot
Copy link

enso-bot bot commented Jun 23, 2023

Greg Travis reports a new STANDUP for today (2023-06-23):

Progress: fixed pg return value; nan/inf handling It should be finished by 2023-06-23.

Next Day: specializations (sigh)

@enso-bot
Copy link

enso-bot bot commented Jun 26, 2023

Greg Travis reports a new 🔴 DELAY for today (2023-06-26):

Summary: There is 1 days delay in implementation of the Add rounding functions to the In-Database Column type (#6886) task.
It will cause 0 days delay for the delivery of this weekly plan.

Delay Cause: return types, builtins

@enso-bot
Copy link

enso-bot bot commented Jun 26, 2023

Greg Travis reports a new 🔴 DELAY for today (2023-06-26):

Summary: There is 2 days delay in implementation of the Add rounding functions to the In-Database Column type (#6886) task.
It will cause 0 days delay for the delivery of this weekly plan.

Delay Cause: return types, builtins

@enso-bot
Copy link

enso-bot bot commented Jun 26, 2023

Greg Travis reports a new STANDUP for today (2023-06-26):

Progress: Rounding return types; using builtin round It should be finished by 2023-06-26.

Next Day: specializations (sigh)

@jdunkerley jdunkerley moved this from 🔧 Implementation to 👁️ Code review in Issues Board Jun 27, 2023
@enso-bot
Copy link

enso-bot bot commented Jun 27, 2023

Greg Travis reports a new 🔴 DELAY for today (2023-06-27):

Summary: There is 1 days delay in implementation of the Add rounding functions to the In-Database Column type (#6886) task.
It will cause 0 days delay for the delivery of this weekly plan.

Delay Cause: Fixing round literal problem

@enso-bot
Copy link

enso-bot bot commented Jun 27, 2023

Greg Travis reports a new STANDUP for today (2023-06-27):

Progress: Fixed round() literal problem, finished rounding review; fill_column tweaks It should be finished by 2023-06-27.

Next Day: fill_column

@enso-bot
Copy link

enso-bot bot commented Jun 28, 2023

Greg Travis reports a new 🔴 DELAY for today (2023-06-28):

Summary: There is 1 days delay in implementation of the Add rounding functions to the In-Database Column type (#6886) task.
It will cause 0 days delay for the delivery of this weekly plan.

Delay Cause: Reimplementing in-mem java column ops

@enso-bot
Copy link

enso-bot bot commented Jun 28, 2023

Greg Travis reports a new STANDUP for today (2023-06-28):

Progress: Reimplement Java ops for round, etc, to allow returning Nothing It should be finished by 2023-06-28.

Next Day: fill_column

@GregoryTravis GregoryTravis linked a pull request Jun 29, 2023 that will close this issue
5 tasks
@enso-bot
Copy link

enso-bot bot commented Jun 29, 2023

Greg Travis reports a new 🔴 DELAY for today (2023-06-29):

Summary: There is 1 days delay in implementation of the Add rounding functions to the In-Database Column type (#6886) task.
It will cause 0 days delay for the delivery of this weekly plan.

Delay Cause: flaky precision test

@enso-bot
Copy link

enso-bot bot commented Jun 29, 2023

Greg Travis reports a new STANDUP for today (2023-06-29):

Progress: Epsilon for flaky sqlite rounding test; fill_nothing/empty for db Table; parse_to_columns row drop bug; combine pattern and regex It should be finished by 2023-06-29.

Next Day: fill_column

@mergify mergify bot closed this as completed in #6988 Jun 30, 2023
@github-project-automation github-project-automation bot moved this from 👁️ Code review to 🟢 Accepted in Issues Board Jun 30, 2023
@enso-bot
Copy link

enso-bot bot commented Jun 30, 2023

Greg Travis reports a new 🔴 DELAY for today (2023-06-30):

Summary: There is 1 days delay in implementation of the Add rounding functions to the In-Database Column type (#6886) task.
It will cause 0 days delay for the delivery of this weekly plan.

Delay Cause: CI failures

@enso-bot
Copy link

enso-bot bot commented Jun 30, 2023

Greg Travis reports a new STANDUP for today (2023-06-30):

Progress: Three reviews; CI test failures; Text.replace regex param It should be finished by 2023-06-30.

Next Day: fill_column

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-libs Libraries: New libraries to be implemented x-new-feature Type: new feature request
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants