Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When showing fullscreen visualization and typing, the Graph Operations are performed in the background. #6754

Closed
2 tasks
sylwiabr opened this issue May 18, 2023 · 0 comments · Fixed by #6844
Closed
2 tasks

When showing fullscreen visualization and typing, the Graph Operations are performed in the background. #6754

sylwiabr opened this issue May 18, 2023 · 0 comments · Fixed by #6844
Assignees
@Procrat
Labels
--bug Type: bug d-easy Difficulty: little prior knowledge required p-high Should be completed in the next sprint
Milestone
Design Partners

Comments

@sylwiabr
Copy link
Member

sylwiabr commented May 18, 2023 •
edited by farmaazon
Loading

Discord username

No response

What type of issue is this?

Permanent – Occurring repeatably

Is this issue blocking you from using Enso?

  • Yes, I can't use Enso because of this issue.

Is this a regression?

  • Yes, previous version of Enso did not have this issue.

What issue are you facing?

If user has the visualization opened for the full screen and press tab or enter the CB pops up in the front.
pressing backspace when full vis is open is deleting the node and the screen is getting blank.

Expected behaviour

No CB - possibly in the future we will allow for more interactions with tables.

How we can reproduce it?

No response

Screenshots or screencasts

image

Enso Version

nightly 18.05

Browser or standalone distribution

Standalone distribution (local project)

Browser Version or standalone distribution

standalone

Operating System

MacOS

Operating System Version

No response

Hardware you are using

No response
@sylwiabr sylwiabr added --bug Type: bug triage labels May 18, 2023
@sylwiabr sylwiabr added the -gui label May 18, 2023
@Frizi Frizi removed the triage label May 18, 2023
@farmaazon farmaazon changed the title Component Browser opens when the visualization is full screen When showing fullscreen visualization and typing, the Graph Operations are performed in the background. May 19, 2023
@farmaazon farmaazon mentioned this issue May 19, 2023
Closed
2 tasks
@farmaazon farmaazon added d-easy Difficulty: little prior knowledge required p-high Should be completed in the next sprint labels May 19, 2023
@farmaazon farmaazon added this to the Design Partners milestone May 19, 2023
@farmaazon farmaazon moved this from ❓New to 📤 Backlog in Issues Board May 19, 2023
@farmaazon farmaazon assigned Procrat and unassigned farmaazon May 24, 2023
@farmaazon farmaazon moved this from 📤 Backlog to 🔧 Implementation in Issues Board May 24, 2023
@Procrat Procrat mentioned this issue May 25, 2023
Merged
5 tasks
@Procrat Procrat moved this from 🔧 Implementation to 👁️ Code review in Issues Board May 25, 2023
@Procrat Procrat moved this from 👁️ Code review to 🌟 Q/A review in Issues Board May 25, 2023
@farmaazon farmaazon moved this from 🌟 Q/A review to 🟢 Accepted in Issues Board May 26, 2023
@mergify mergify bot closed this as completed in #6844 May 26, 2023
mergify bot pushed a commit that referenced this issue May 26, 2023
@Procrat
Stop graph editing when in full-screen visualization mode (#6844)
e9761f5 
Fixes #6754. The issue mentions being able to create and delete nodes when the full-screen visualisation is active. Besides those, you now also can't:
- collapse nodes into a function
- enter a function
- exit a function
@farmaazon farmaazon moved this from 🟢 Accepted to 🗄️ Archived in Issues Board May 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Procrat Procrat

Labels
--bug Type: bug d-easy Difficulty: little prior knowledge required p-high Should be completed in the next sprint
Projects
Issues Board
Archived in project
Milestone
Design Partners
Development

Successfully merging a pull request may close this issue.

Stop graph editing when in full-screen visualization mode enso-org/enso
4 participants
@Procrat @Frizi @farmaazon @sylwiabr