Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pressing ctrl+click to start edit a node and then clicking in the background is replacing the content with the content from previously edited node #6411

Closed
1 of 2 tasks
sylwiabr opened this issue Apr 25, 2023 · 11 comments · Fixed by #6594
Closed
1 of 2 tasks

Pressing ctrl+click to start edit a node and then clicking in the background is replacing the content with the content from previously edited node #6411

sylwiabr opened this issue Apr 25, 2023 · 11 comments · Fixed by #6594
Assignees
@vitvakatu
Labels
--bug Type: bug --regression Important: regression p-highest Should be completed ASAP
Milestone
Design Partners

Comments

@sylwiabr
Copy link
Member

sylwiabr commented Apr 25, 2023 •
edited
Loading

Discord username

No response

What type of issue is this?

Permanent – Occurring repeatably

Is this issue blocking you from using Enso?

  • Yes, I can't use Enso because of this issue.

Is this a regression?

  • Yes, previous version of Enso did not have this issue.

What issue are you facing?

edit_bug.mov

Expected behaviour

Content of the node should not change.

How we can reproduce it?

  1. open new project
  2. add a node
  3. start editing the added node and click on the background
  4. start editing the default node and click on the background without any changes to the node content

Screenshots or screencasts

No response

Enso Version

Nightly 25.04.2023

Browser or standalone distribution

Standalone distribution

Browser Version or standalone distribution

standalone

Operating System

MacOS

Operating System Version

No response

Hardware you are using

No response
@sylwiabr sylwiabr added --bug Type: bug triage labels Apr 25, 2023
@sylwiabr sylwiabr added the p-highest Should be completed ASAP label Apr 25, 2023
@sylwiabr
Copy link
Member Author

In the package from 22.04 the node was disappearing if I clicked to edit and then clicked in the background but the content was not replaced. the issue with vanishing node is described here: #6378

@vitvakatu
Copy link
Contributor

We need to check it on branch #6347. If it is not fixed there, the issue is somewhere in CB, and the fix can be complicated. I was facing similar issues while working on cursor-aware CB, but at that time, everything was fixed.

@vitvakatu vitvakatu added -gui and removed triage labels Apr 25, 2023
@hubertp
Copy link
Collaborator

hubertp commented Apr 25, 2023 •
edited
Loading

Maybe slightly related:

  • select a method from CB (e.g. aggregate)
  • ctrl+click to edit the newly added node
  • click outside

Screenshot from 2023-04-25 14-42-33

I would expect that we revert to the old node since clicking outside (I think) meant the cancellation of the edit action.
Instead it picks a random fragment from the node's name and disconnects the edge.

@vitvakatu vitvakatu added this to the Design Partners milestone Apr 25, 2023
@vitvakatu
Copy link
Contributor

It is reproducible on #6347

@sylwiabr sylwiabr added the --regression Important: regression label Apr 26, 2023
@MichaelMauderer MichaelMauderer mentioned this issue Apr 26, 2023
Closed
2 tasks
@vitvakatu vitvakatu assigned vitvakatu and unassigned farmaazon Apr 26, 2023
@vitvakatu vitvakatu moved this from ❓New to 🔧 Implementation in Issues Board Apr 28, 2023
@sylwiabr
Copy link
Member Author

sylwiabr commented May 5, 2023

@vitvakatu what is the status here?

@vitvakatu
Copy link
Contributor

@sylwiabr the fix is ready, the PR will be here today.

@vitvakatu vitvakatu mentioned this issue May 7, 2023
Merged
5 tasks
@vitvakatu vitvakatu moved this from 🔧 Implementation to 👁️ Code review in Issues Board May 7, 2023
This was referenced May 7, 2023
Closed
Closed
Closed
@vitvakatu vitvakatu moved this from 👁️ Code review to 🌟 Q/A review in Issues Board May 8, 2023
@mergify mergify bot closed this as completed in #6594 May 9, 2023
mergify bot pushed a commit that referenced this issue May 9, 2023
@vitvakatu
Fix node editing race condition (#6594)
b0ce2a8 
Fixes #6411

The issue was quite popular `map2` instead of `all_with`. I also updated the code to use the modern `debounce` API instead of a hacky 0-millisecond timer.

The FRP of the project view is extremely complicated in this place, and similar race conditions can appear out of nowhere. We must consider refactoring the current implementation (everything connected to the CB).
@github-project-automation github-project-automation bot moved this from 🌟 Q/A review to 🟢 Accepted in Issues Board May 9, 2023
@farmaazon farmaazon moved this from 🟢 Accepted to 🗄️ Archived in Issues Board May 10, 2023
@Akirathan Akirathan mentioned this issue May 15, 2023
Closed
2 tasks
@enso-bot
Copy link

enso-bot bot commented Jul 19, 2023

Ilya Bogdanov reports a new STANDUP for the provided date (2023-04-28):

Progress: Investigating the issue with ctrl-clicking into the node. It should be finished by 2023-05-05.

@enso-bot
Copy link

enso-bot bot commented Jul 19, 2023

Ilya Bogdanov reports a new STANDUP for the provided date (2023-05-02):

Progress: Investigating ctrl-clicking issue. It should be finished by 2023-05-05.

@enso-bot
Copy link

enso-bot bot commented Jul 19, 2023

Ilya Bogdanov reports a new STANDUP for the provided date (2023-05-03):

Progress: Investigating ctrl-clicking issue. It should be finished by 2023-05-05.

@enso-bot
Copy link

enso-bot bot commented Jul 19, 2023

Ilya Bogdanov reports a new STANDUP for the provided date (2023-05-04):

Progress: Investigating ctrl-clicking issue. It should be finished by 2023-05-05.

@enso-bot
Copy link

enso-bot bot commented Jul 19, 2023

Ilya Bogdanov reports a new STANDUP for the provided date (2023-05-05):

Progress: Investigating ctrl-clicking issue. It should be finished by 2023-05-05.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vitvakatu vitvakatu

Labels
--bug Type: bug --regression Important: regression p-highest Should be completed ASAP
Projects
Issues Board
Archived in project
Milestone
Design Partners
Development

Successfully merging a pull request may close this issue.

Fix node editing race condition enso-org/enso
4 participants
@hubertp @farmaazon @vitvakatu @sylwiabr