Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

from_rows and new suggestions in CB while opening with the Table selected #5874

Closed
2 tasks
sylwiabr opened this issue Mar 9, 2023 · 5 comments · Fixed by #6036
Closed
2 tasks

from_rows and new suggestions in CB while opening with the Table selected #5874

sylwiabr opened this issue Mar 9, 2023 · 5 comments · Fixed by #6036
Assignees

Comments

@sylwiabr
Copy link
Member

sylwiabr commented Mar 9, 2023

Discord username

No response

What type of issue is this?

Permanent – Ocurring repeatably

Is this issue blocking you from using Enso?

  • Yes, I can't use Enso because of this issue.

Is this a regression?

  • Yes, previous version of Enso did not have this issue.

What issue are you facing?

When I open a CB with Table selected I am getting from_rows and Table.new as the best suggestions - they are invalid and choosing those would create always a node with an error.
image

Expected behaviour

We should not suggest both of those when working with already created table.

How we can reproduce it?

No response

Screenshots or screencasts

No response

Enso Version

Nightly 9.03.2023

Browser or standalone distribution

Standalone distribution

Browser Version or standalone distribution

standalone

Operating System

MacOS

Operating System Version

No response

Hardware you are using

No response

@farmaazon
Copy link
Contributor

@4e6 is it hard to make searcher/component skipping static methods if called with this parameter? I know we want to resign from it, but we are still far on the IDE side.

@jdunkerley jdunkerley added this to the Beta Release milestone Mar 10, 2023
@jdunkerley jdunkerley moved this from ❓New to 📤 Backlog in Issues Board Mar 14, 2023
@4e6
Copy link
Contributor

4e6 commented Mar 20, 2023

Yes, I think it is possible. I'll take a look

@enso-bot
Copy link

enso-bot bot commented Mar 20, 2023

Dmitry Bushev reports a new STANDUP for today (2023-03-20):

Progress: Started working on the task. Was able to reproduce the issue. The fix could be just to filter out static suggestions whenever the self-type is provided. Started working on the fix. It should be finished by 2023-03-22.

Next Day: Next day I will be working on the #5874 task. Continue working on the task

@enso-bot
Copy link

enso-bot bot commented Mar 22, 2023

Dmitry Bushev reports a new STANDUP for yesterday (2023-03-21):

Progress: Started working on the task. Found out that simply filtering the non-static members on the engine side is lightly wrong, and instead added one extra parameter to the search request allowing us to search by static attribute of suggestions. It should be finished by 2023-03-22.

Next Day: Next day I will be working on the #5874 task. Continue working on the task

@enso-bot
Copy link

enso-bot bot commented Mar 22, 2023

Dmitry Bushev reports a new STANDUP for today (2023-03-22):

Progress: Continue working on the task. Finished the filtering logic and fixed the tests. Struggled with IDE tests as they take a long time to re-run. Created a PR It should be finished by 2023-03-22.

Next Day: Next day I will be working on the #5874 task. Continue working on the task

@mergify mergify bot closed this as completed in #6036 Mar 23, 2023
mergify bot pushed a commit that referenced this issue Mar 23, 2023
close #5874

Changelog:
- add: `isStatic` parameter to `search/completion` request to search by the `static` suggestion attribute
- update: search non-static suggestions when opening component browser

# Important Notes
Component browser doesn't show `Table.new` and `Table.from_rows` suggestions when a `Table` node is selected.

![2023-03-21-151117_1301x877_scrot](https://user-images.githubusercontent.com/357683/226874291-1ff99994-1bb6-41df-96b4-dc5c5178ba41.png)
@github-project-automation github-project-automation bot moved this from 📤 Backlog to 🟢 Accepted in Issues Board Mar 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants