-
Notifications
You must be signed in to change notification settings - Fork 326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
from_rows
and new
suggestions in CB while opening with the Table
selected
#5874
Comments
@4e6 is it hard to make |
Yes, I think it is possible. I'll take a look |
Dmitry Bushev reports a new STANDUP for today (2023-03-20): Progress: Started working on the task. Was able to reproduce the issue. The fix could be just to filter out static suggestions whenever the self-type is provided. Started working on the fix. It should be finished by 2023-03-22. Next Day: Next day I will be working on the #5874 task. Continue working on the task |
Dmitry Bushev reports a new STANDUP for yesterday (2023-03-21): Progress: Started working on the task. Found out that simply filtering the non-static members on the engine side is lightly wrong, and instead added one extra parameter to the search request allowing us to search by static attribute of suggestions. It should be finished by 2023-03-22. Next Day: Next day I will be working on the #5874 task. Continue working on the task |
Dmitry Bushev reports a new STANDUP for today (2023-03-22): Progress: Continue working on the task. Finished the filtering logic and fixed the tests. Struggled with IDE tests as they take a long time to re-run. Created a PR It should be finished by 2023-03-22. Next Day: Next day I will be working on the #5874 task. Continue working on the task |
close #5874 Changelog: - add: `isStatic` parameter to `search/completion` request to search by the `static` suggestion attribute - update: search non-static suggestions when opening component browser # Important Notes Component browser doesn't show `Table.new` and `Table.from_rows` suggestions when a `Table` node is selected. 
Discord username
No response
What type of issue is this?
Permanent – Ocurring repeatably
Is this issue blocking you from using Enso?
Is this a regression?
What issue are you facing?
When I open a CB with

Table
selected I am gettingfrom_rows
andTable.new
as the best suggestions - they are invalid and choosing those would create always a node with an error.Expected behaviour
We should not suggest both of those when working with already created table.
How we can reproduce it?
No response
Screenshots or screencasts
No response
Enso Version
Nightly 9.03.2023
Browser or standalone distribution
Standalone distribution
Browser Version or standalone distribution
standalone
Operating System
MacOS
Operating System Version
No response
Hardware you are using
No response
The text was updated successfully, but these errors were encountered: