-
Notifications
You must be signed in to change notification settings - Fork 326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Parameter formatting is broken with TruffleLoggers #5801
Milestone
Comments
There is a Builder.logHandler(...) method. If we use it, we get The implementation must be somewhere in PolyglotLoggers. |
Running
they deserve to be properly formatted. |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Logs coming out of TruffleLogger don't use the provided arguments leading to incomplete messages:
Notice the
{0}
for parameter position which should have been replaced with the correct argument.As per logs in https://github.com/enso-org/enso/blob/develop/engine/runtime-language-epb/src/main/java/org/enso/interpreter/epb/EpbContext.java#L66 or https://github.com/enso-org/enso/blob/develop/engine/runtime-language-epb/src/main/java/org/enso/interpreter/epb/EpbContext.java#L80.
Those logs were introduced in #5680 but I can see plenty of places where we could use parameter formatting except we can't so logs are full of String concatenation (also affecting performance).
The text was updated successfully, but these errors were encountered: