-
Notifications
You must be signed in to change notification settings - Fork 326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Table visualization incorrectly renders custom Enso objects #5480
Comments
It seems the issue is in the logic of table visualization (see |
JSON serialization of an Object should include the |
Table.js now has support for While here steal ownership! |
Include rendering of JS_Object. |
James Dunkerley reports a new STANDUP for today (2023-04-20): Progress: Dealt with odd issue on Postgres for trim. Completed PR comments. Demo with Luable. Looking at grid rendering for custom objects and date issue. It should be finished by 2023-04-21. Next Day: Next day I will be working on the #5480 task. Onto S3 and cloud... |
James Dunkerley reports a new STANDUP for today (2023-04-21): Progress: Working through adjusting the serialization format for the Table viz. Added Next Day: Next day I will be working on the #5480 task. Onto S3 and cloud... |
This task is automatically imported from the old Task Issue Board and it was originally created by Radosław Waśko.
Original issue is here.
See Discord thread https://discord.com/channels/401396655599124480/978315597400145920/978316216408092763
Steps to reproduce
import Standard.Table
is included at the beginning.Table.new [["foo", [Ordering.Less, Ordering.Equal]]]
.Table
.Expected
The visualization cells should display
Less
andEqual
.Actual
They display
[object Object]
instead.Comment
For comparison, if we add a node
. at "foo" . to_vector
and show theTable
visualization on the Vector type, it is displayed correctly. So the logic for vectors seems to be correct and the logic for tables seems to lack something, but it should be fairly easy to just adapt the logic from vectors.Comments:
Screenshots of the described repro. (Radosław Waśko - May 23, 2022)
The text was updated successfully, but these errors were encountered: