Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Table visualization incorrectly renders custom Enso objects #5480

Closed
wdanilo opened this issue Feb 5, 2023 · 6 comments · Fixed by #6382
Closed

Table visualization incorrectly renders custom Enso objects #5480

wdanilo opened this issue Feb 5, 2023 · 6 comments · Fixed by #6382
Assignees
Labels
--bug Type: bug -libs Libraries: New libraries to be implemented -viz d-easy Difficulty: little prior knowledge required p-low Low priority

Comments

@wdanilo
Copy link
Member

wdanilo commented Feb 5, 2023

This task is automatically imported from the old Task Issue Board and it was originally created by Radosław Waśko.
Original issue is here.


See Discord thread https://discord.com/channels/401396655599124480/978315597400145920/978316216408092763

Steps to reproduce

  1. Make sure that import Standard.Table is included at the beginning.
  2. Create a node Table.new [["foo", [Ordering.Less, Ordering.Equal]]].
  3. Show the visualization and switch it to Table.

Expected

The visualization cells should display Less and Equal.

Actual

They display [object Object] instead.

Comment

For comparison, if we add a node . at "foo" . to_vector and show the Table visualization on the Vector type, it is displayed correctly. So the logic for vectors seems to be correct and the logic for tables seems to lack something, but it should be fairly easy to just adapt the logic from vectors.

Comments:

Screenshots of the described repro. (Radosław Waśko - May 23, 2022)


@sylwiabr sylwiabr added this to the Beta Release milestone Feb 6, 2023
@sylwiabr sylwiabr moved this to ❓New in Issues Board Feb 6, 2023
@sylwiabr sylwiabr added the triage label Feb 6, 2023
@vitvakatu
Copy link
Contributor

It seems the issue is in the logic of table visualization (see toTableCell function).

@vitvakatu vitvakatu moved this from ❓New to 📤 Backlog in Issues Board Feb 13, 2023
@vitvakatu vitvakatu added d-easy Difficulty: little prior knowledge required and removed triage labels Feb 13, 2023
@vitvakatu vitvakatu assigned vitvakatu and farmaazon and unassigned vitvakatu Feb 13, 2023
@farmaazon farmaazon removed the -gui label Feb 21, 2023
@farmaazon farmaazon assigned mwu-tow and unassigned farmaazon Feb 24, 2023
@jdunkerley jdunkerley added the -libs Libraries: New libraries to be implemented label Mar 7, 2023
@jdunkerley
Copy link
Member

JSON serialization of an Object should include the to_display_text within the Table viz.
This can then be used within table.js to render the value. This can also remove the Date, Time_Of_Day and Date_Time workaround.

@jdunkerley jdunkerley assigned jdunkerley and unassigned mwu-tow Mar 21, 2023
@jdunkerley
Copy link
Member

Table.js now has support for _DISPLAY_TEXT_.
This ticket is to update the enso serialization to add that and simplify the table.js

While here steal ownership!

@jdunkerley
Copy link
Member

Include rendering of JS_Object.

@jdunkerley jdunkerley moved this from 📤 Backlog to ❓New in Issues Board Mar 28, 2023
@jdunkerley jdunkerley moved this from ❓New to 📤 Backlog in Issues Board Mar 28, 2023
@jdunkerley jdunkerley moved this from 📤 Backlog to 🔧 Implementation in Issues Board Apr 20, 2023
@enso-bot
Copy link

enso-bot bot commented Apr 20, 2023

James Dunkerley reports a new STANDUP for today (2023-04-20):

Progress: Dealt with odd issue on Postgres for trim. Completed PR comments. Demo with Luable. Looking at grid rendering for custom objects and date issue. It should be finished by 2023-04-21.

Next Day: Next day I will be working on the #5480 task. Onto S3 and cloud...

@jdunkerley jdunkerley linked a pull request Apr 21, 2023 that will close this issue
5 tasks
@enso-bot
Copy link

enso-bot bot commented Apr 21, 2023

James Dunkerley reports a new STANDUP for today (2023-04-21):

Progress: Working through adjusting the serialization format for the Table viz. Added to_display_text to many types missing it. It should be finished by 2023-04-21.

Next Day: Next day I will be working on the #5480 task. Onto S3 and cloud...

@mergify mergify bot closed this as completed in #6382 Apr 26, 2023
@github-project-automation github-project-automation bot moved this from 🔧 Implementation to 🟢 Accepted in Issues Board Apr 26, 2023
@farmaazon farmaazon moved this from 🟢 Accepted to 🗄️ Archived in Issues Board May 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
--bug Type: bug -libs Libraries: New libraries to be implemented -viz d-easy Difficulty: little prior knowledge required p-low Low priority
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

7 participants