Add compiler pass that discovers ambiguous imports (#6868)

Add a new compiler pass that analyses duplicated and ambiguous symbols from imports
enso-org · Jun 14, 2023 · 67821bf · 67821bf
1 parent d9ed63f
commit 67821bf
Show file tree

Hide file tree

Showing 87 changed files with 864 additions and 141 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -818,6 +818,7 @@
 - [Add project creation time to project metadata][6780]
 - [Upgrade GraalVM to 22.3.1 JDK17][6750]
 - [Ascribed types are checked during runtime][6790]
+- [Add compiler pass that discovers ambiguous and duplicated symbols][6868]
 - [Improve and colorize compiler's diagnostic messages][6931]
 - [Execute some runtime commands synchronously to avoid race conditions][6998]
 
@@ -934,6 +935,7 @@
 [6755]: https://github.com/enso-org/enso/pull/6755
 [6780]: https://github.com/enso-org/enso/pull/6780
 [6790]: https://github.com/enso-org/enso/pull/6790
+[6868]: https://github.com/enso-org/enso/pull/6868
 [6931]: https://github.com/enso-org/enso/pull/6931
 [6998]: https://github.com/enso-org/enso/pull/6998
 

diff --git a/distribution/lib/Standard/Base/0.0.0-dev/src/Any.enso b/distribution/lib/Standard/Base/0.0.0-dev/src/Any.enso
@@ -1,5 +1,5 @@
 import project.Data.Pair.Pair
-import project.Data.Range.Extensions
+from project.Data.Range.Extensions import all
 import project.Data.Text.Text
 import project.Data.Vector.Vector
 import project.Error.Error

diff --git a/distribution/lib/Standard/Base/0.0.0-dev/src/Data/Array.enso b/distribution/lib/Standard/Base/0.0.0-dev/src/Data/Array.enso
@@ -3,9 +3,9 @@ import project.Data.Numbers.Integer
 import project.Data.Filter_Condition.Filter_Condition
 import project.Data.List.List
 import project.Data.Ordering.Ordering
-import project.Data.Ordering.Sort_Direction.Sort_Direction
+import project.Data.Sort_Direction.Sort_Direction
 import project.Data.Pair.Pair
-import project.Data.Range.Extensions
+from project.Data.Range.Extensions import all
 import project.Data.Range.Range
 import project.Data.Text.Text
 import project.Data.Vector.Vector

diff --git a/distribution/lib/Standard/Base/0.0.0-dev/src/Data/Filter_Condition.enso b/distribution/lib/Standard/Base/0.0.0-dev/src/Data/Filter_Condition.enso
@@ -1,7 +1,6 @@
 import project.Any.Any
-import project.Data.Boolean.Boolean
 import project.Data.Text.Case_Sensitivity.Case_Sensitivity
-import project.Data.Text.Extensions
+from project.Data.Text.Extensions import all
 import project.Data.Text.Regex
 import project.Data.Text.Text
 import project.Data.Vector.Vector

diff --git a/distribution/lib/Standard/Base/0.0.0-dev/src/Data/Index_Sub_Range.enso b/distribution/lib/Standard/Base/0.0.0-dev/src/Data/Index_Sub_Range.enso
@@ -1,7 +1,7 @@
 import project.Any.Any
 import project.Data.Numbers.Integer
 import project.Data.Range.Range
-import project.Data.Range.Extensions
+from project.Data.Range.Extensions import all
 import project.Data.Text.Text
 import project.Data.Vector.Vector
 import project.Errors.Common.Index_Out_Of_Bounds

diff --git a/distribution/lib/Standard/Base/0.0.0-dev/src/Data/Json.enso b/distribution/lib/Standard/Base/0.0.0-dev/src/Data/Json.enso
@@ -1,13 +1,13 @@
 import project.Any.Any
 import project.Data.Array.Array
 import project.Data.Array_Proxy.Array_Proxy
-import project.Data.Json.Extensions
+from project.Data.Json.Extensions import all
 import project.Data.Map.Map
 import project.Data.Numbers.Integer
 import project.Data.Numbers.Number
 import project.Data.Pair.Pair
-import project.Data.Range.Extensions
-import project.Data.Text.Extensions
+from project.Data.Range.Extensions import all
+from project.Data.Text.Extensions import all
 import project.Data.Text.Text
 import project.Data.Vector.Vector
 import project.Errors.Common.Type_Error

diff --git a/distribution/lib/Standard/Base/0.0.0-dev/src/Data/Json/Extensions.enso b/distribution/lib/Standard/Base/0.0.0-dev/src/Data/Json/Extensions.enso
@@ -8,8 +8,8 @@ import project.Data.Map.Map
 import project.Data.Numbers.Decimal
 import project.Data.Numbers.Integer
 import project.Data.Numbers.Number
-import project.Data.Range.Extensions
-import project.Data.Text.Extensions
+from project.Data.Range.Extensions import all
+from project.Data.Text.Extensions import all
 import project.Data.Text.Text
 import project.Data.Text.Text_Sub_Range.Text_Sub_Range
 import project.Data.Vector.Vector

diff --git a/distribution/lib/Standard/Base/0.0.0-dev/src/Data/Locale.enso b/distribution/lib/Standard/Base/0.0.0-dev/src/Data/Locale.enso
@@ -1,7 +1,7 @@
 import project.Any.Any
 import project.Data.Filter_Condition.Filter_Condition
 import project.Data.Text.Case.Case
-import project.Data.Text.Extensions
+from project.Data.Text.Extensions import all
 import project.Data.Text.Text
 import project.Data.Vector.Vector
 import project.Metadata.Display

diff --git a/distribution/lib/Standard/Base/0.0.0-dev/src/Data/Map.enso b/distribution/lib/Standard/Base/0.0.0-dev/src/Data/Map.enso
@@ -2,7 +2,7 @@ import project.Any.Any
 import project.Data.Numbers.Integer
 import project.Data.Vector.Vector
 import project.Data.Pair.Pair
-import project.Data.Text.Extensions
+from project.Data.Text.Extensions import all
 import project.Data.Text.Text
 import project.Error.Error
 import project.Errors.Illegal_Argument.Illegal_Argument

diff --git a/distribution/lib/Standard/Base/0.0.0-dev/src/Data/Pair.enso b/distribution/lib/Standard/Base/0.0.0-dev/src/Data/Pair.enso
@@ -2,7 +2,7 @@ import project.Any.Any
 import project.Data.Boolean.Boolean
 import project.Data.Numbers.Integer
 import project.Data.Text.Text
-import project.Data.Text.Extensions
+from project.Data.Text.Extensions import all
 import project.Data.Vector.Vector
 import project.Errors.Common.Index_Out_Of_Bounds
 import project.Errors.Common.Not_Found

diff --git a/distribution/lib/Standard/Base/0.0.0-dev/src/Data/Set.enso b/distribution/lib/Standard/Base/0.0.0-dev/src/Data/Set.enso
@@ -5,7 +5,7 @@ import project.Data.Numbers.Integer
 import project.Data.Ordering.Comparable
 import project.Data.Ordering.Ordering
 import project.Data.Vector.Vector
-import project.Data.Text.Extensions
+from project.Data.Text.Extensions import all
 import project.Data.Text.Text
 import project.Errors.Illegal_Argument.Illegal_Argument
 import project.Nothing.Nothing

diff --git a/...dev/src/Data/Ordering/Sort_Direction.enso → ...se/0.0.0-dev/src/Data/Sort_Direction.enso b/...dev/src/Data/Ordering/Sort_Direction.enso → ...se/0.0.0-dev/src/Data/Sort_Direction.enso
diff --git a/distribution/lib/Standard/Base/0.0.0-dev/src/Data/Statistics.enso b/distribution/lib/Standard/Base/0.0.0-dev/src/Data/Statistics.enso
@@ -5,7 +5,7 @@ import project.Data.Numbers.Integer
 import project.Data.Numbers.Number
 import project.Data.Ordering.Ordering
 import project.Data.Ordering.Comparable
-import project.Data.Range.Extensions
+from project.Data.Range.Extensions import all
 import project.Data.Vector.Vector
 import project.Errors.Common.Incomparable_Values
 import project.Error.Error

diff --git a/distribution/lib/Standard/Base/0.0.0-dev/src/Data/Text/Extensions.enso b/distribution/lib/Standard/Base/0.0.0-dev/src/Data/Text/Extensions.enso
@@ -4,7 +4,7 @@ import project.Any.Any
 import project.Data.Array.Array
 import project.Data.Index_Sub_Range.Index_Sub_Range
 import project.Data.Locale.Locale
-import project.Data.Range.Extensions
+from project.Data.Range.Extensions import all
 import project.Data.Range.Range
 import project.Data.Text.Case.Case
 import project.Data.Text.Case_Sensitivity.Case_Sensitivity
@@ -38,7 +38,6 @@ import project.Nothing.Nothing
 from project.Data.Boolean import Boolean, True, False
 from project.Data.Json import Json, Invalid_JSON, JS_Object
 from project.Data.Numbers import Decimal, Integer, Number, Number_Parse_Error
-from project.Data.Text.Text_Sub_Range import Codepoint_Ranges, Text_Sub_Range
 
 from project.Widget_Helpers import make_delimiter_selector
 

diff --git a/distribution/lib/Standard/Base/0.0.0-dev/src/Data/Text/Regex/Match.enso b/distribution/lib/Standard/Base/0.0.0-dev/src/Data/Text/Regex/Match.enso
@@ -1,7 +1,7 @@
 import project.Any.Any
 import project.Data.Map.Map
 import project.Data.Numbers.Integer
-import project.Data.Range.Extensions
+from project.Data.Range.Extensions import all
 import project.Data.Range.Range
 import project.Data.Text.Regex.No_Such_Group
 import project.Data.Text.Regex.Pattern.Pattern

diff --git a/distribution/lib/Standard/Base/0.0.0-dev/src/Data/Text/Regex/Pattern.enso b/distribution/lib/Standard/Base/0.0.0-dev/src/Data/Text/Regex/Pattern.enso
@@ -2,9 +2,9 @@ import project.Any.Any
 import project.Data.Filter_Condition.Filter_Condition
 import project.Data.Map.Map
 import project.Data.Numbers.Integer
-import project.Data.Range.Extensions
+from project.Data.Range.Extensions import all
 import project.Data.Range.Range
-import project.Data.Text.Extensions
+from project.Data.Text.Extensions import all
 import project.Data.Text.Helpers
 import project.Data.Text.Span.Span
 import project.Data.Text.Span.Utf_16_Span

diff --git a/distribution/lib/Standard/Base/0.0.0-dev/src/Data/Text/Regex/Replacer.enso b/distribution/lib/Standard/Base/0.0.0-dev/src/Data/Text/Regex/Replacer.enso
@@ -1,5 +1,5 @@
 import project.Data.Numbers.Integer
-import project.Data.Text.Extensions
+from project.Data.Text.Extensions import all
 import project.Data.Text.Regex
 import project.Data.Text.Regex.Match.Match
 import project.Data.Text.Regex.No_Such_Group

diff --git a/distribution/lib/Standard/Base/0.0.0-dev/src/Data/Text/Span.enso b/distribution/lib/Standard/Base/0.0.0-dev/src/Data/Text/Span.enso
@@ -11,7 +11,7 @@
 
 import project.Data.Numbers.Integer
 import project.Data.Pair.Pair
-import project.Data.Range.Extensions
+from project.Data.Range.Extensions import all
 import project.Data.Range.Range
 import project.Data.Text.Text
 import project.Errors.Common.Index_Out_Of_Bounds

diff --git a/distribution/lib/Standard/Base/0.0.0-dev/src/Data/Text/Text_Sub_Range.enso b/distribution/lib/Standard/Base/0.0.0-dev/src/Data/Text/Text_Sub_Range.enso
@@ -1,7 +1,7 @@
 import project.Data.Index_Sub_Range.Index_Sub_Range
 import project.Data.Numbers.Integer
 import project.Data.Pair.Pair
-import project.Data.Range.Extensions
+from project.Data.Range.Extensions import all
 import project.Data.Range.Range
 import project.Data.Text.Text
 import project.Data.Vector.Vector

diff --git a/distribution/lib/Standard/Base/0.0.0-dev/src/Data/Time/Date_Range.enso b/distribution/lib/Standard/Base/0.0.0-dev/src/Data/Time/Date_Range.enso
@@ -3,7 +3,7 @@ import project.Data.Filter_Condition.Filter_Condition
 import project.Data.Json.JS_Object
 import project.Data.Numbers.Integer
 import project.Data.Range.Empty_Error
-import project.Data.Range.Extensions
+from project.Data.Range.Extensions import all
 import project.Data.Text.Text
 import project.Data.Time.Date.Date
 import project.Data.Time.Date_Period.Date_Period

diff --git a/distribution/lib/Standard/Base/0.0.0-dev/src/Data/Time/Duration.enso b/distribution/lib/Standard/Base/0.0.0-dev/src/Data/Time/Duration.enso
@@ -4,7 +4,7 @@ import project.Data.Numbers.Decimal
 import project.Data.Numbers.Integer
 import project.Data.Ordering.Comparable
 import project.Data.Pair.Pair
-import project.Data.Text.Extensions
+from project.Data.Text.Extensions import all
 import project.Data.Text.Text
 import project.Data.Time.Date_Time.Date_Time
 import project.Data.Time.Period.Period

diff --git a/distribution/lib/Standard/Base/0.0.0-dev/src/Data/Time/Period.enso b/distribution/lib/Standard/Base/0.0.0-dev/src/Data/Time/Period.enso
@@ -2,7 +2,7 @@ import project.Any.Any
 import project.Data.Json.JS_Object
 import project.Data.Numbers.Integer
 import project.Data.Ordering.Comparable
-import project.Data.Text.Extensions
+from project.Data.Text.Extensions import all
 import project.Data.Text.Text
 import project.Data.Time.Date.Date
 import project.Data.Time.Duration.Duration

diff --git a/distribution/lib/Standard/Base/0.0.0-dev/src/Data/Vector.enso b/distribution/lib/Standard/Base/0.0.0-dev/src/Data/Vector.enso
@@ -4,11 +4,11 @@ import project.Data.Filter_Condition.Filter_Condition
 import project.Data.List.List
 import project.Data.Map.Map
 import project.Data.Numbers.Integer
-import project.Data.Ordering.Sort_Direction.Sort_Direction
 import project.Data.Pair.Pair
 import project.Data.Range.Range
-import project.Data.Range.Extensions
+from project.Data.Range.Extensions import all
 import project.Data.Text.Text
+import project.Data.Sort_Direction.Sort_Direction
 import project.Errors.Common.Incomparable_Values
 import project.Errors.Common.Index_Out_Of_Bounds
 import project.Errors.Common.No_Such_Method

diff --git a/distribution/lib/Standard/Base/0.0.0-dev/src/Errors/Problem_Behavior.enso b/distribution/lib/Standard/Base/0.0.0-dev/src/Errors/Problem_Behavior.enso
@@ -2,7 +2,6 @@ import project.Any.Any
 import project.Data.Vector.Vector
 import project.Error.Error
 import project.Warning.Warning
-from project import all
 
 from project.Errors.Problem_Behavior.Problem_Behavior import all
 

diff --git a/distribution/lib/Standard/Base/0.0.0-dev/src/Main.enso b/distribution/lib/Standard/Base/0.0.0-dev/src/Main.enso
@@ -74,7 +74,7 @@ import project.Data.Filter_Condition.Filter_Condition
 import project.Data.Index_Sub_Range.Index_Sub_Range
 import project.Data.Interval.Bound
 import project.Data.Interval.Interval
-import project.Data.Json.Extensions
+from project.Data.Json.Extensions import all
 import project.Data.Json.Json
 import project.Data.Json.JS_Object
 import project.Data.Locale.Locale
@@ -84,16 +84,16 @@ import project.Data.Ordering.Natural_Order
 import project.Data.Ordering.Ordering
 import project.Data.Ordering.Comparable
 import project.Data.Ordering.Default_Comparator
-import project.Data.Ordering.Sort_Direction.Sort_Direction
+import project.Data.Sort_Direction.Sort_Direction
 import project.Data.Pair.Pair
 import project.Data.Range.Range
-import project.Data.Range.Extensions
+from project.Data.Range.Extensions import all
 import project.Data.Regression
 import project.Data.Statistics
 import project.Data.Text.Case.Case
 import project.Data.Text.Case_Sensitivity.Case_Sensitivity
 import project.Data.Text.Encoding.Encoding
-import project.Data.Text.Extensions
+from project.Data.Text.Extensions import all
 import project.Data.Text.Line_Ending_Style.Line_Ending_Style
 import project.Data.Text.Location.Location
 import project.Data.Text.Matching_Mode.Matching_Mode
@@ -112,7 +112,7 @@ import project.Data.Time.Time_Of_Day.Time_Of_Day
 import project.Data.Time.Time_Period.Time_Period
 import project.Data.Time.Time_Zone.Time_Zone
 import project.Errors.Problem_Behavior.Problem_Behavior
-import project.Network.Extensions
+from project.Network.Extensions import all
 import project.Network.HTTP.Header.Header
 import project.Network.HTTP.HTTP
 import project.Network.HTTP.HTTP_Method.HTTP_Method
@@ -126,7 +126,7 @@ export project.Data.Filter_Condition.Filter_Condition
 export project.Data.Index_Sub_Range.Index_Sub_Range
 export project.Data.Interval.Bound
 export project.Data.Interval.Interval
-export project.Data.Json.Extensions
+from project.Data.Json.Extensions export all
 export project.Data.Json.Json
 export project.Data.Json.JS_Object
 export project.Data.Locale.Locale
@@ -135,15 +135,15 @@ export project.Data.Ordering.Natural_Order
 export project.Data.Ordering.Ordering
 export project.Data.Ordering.Comparable
 export project.Data.Ordering.Default_Comparator
-export project.Data.Ordering.Sort_Direction.Sort_Direction
 export project.Data.Pair.Pair
 export project.Data.Range.Range
-export project.Data.Range.Extensions
+from project.Data.Range.Extensions export all
 export project.Data.Regression
+export project.Data.Sort_Direction.Sort_Direction
 export project.Data.Text.Case.Case
 export project.Data.Text.Case_Sensitivity.Case_Sensitivity
 export project.Data.Text.Encoding.Encoding
-export project.Data.Text.Extensions
+from project.Data.Text.Extensions export all
 export project.Data.Text.Line_Ending_Style.Line_Ending_Style
 export project.Data.Text.Location.Location
 export project.Data.Text.Matching_Mode.Matching_Mode
@@ -162,7 +162,7 @@ export project.Data.Time.Time_Of_Day.Time_Of_Day
 export project.Data.Time.Time_Period.Time_Period
 export project.Data.Time.Time_Zone.Time_Zone
 export project.Errors.Problem_Behavior.Problem_Behavior
-export project.Network.Extensions
+from project.Network.Extensions export all
 export project.Network.HTTP.Header.Header
 export project.Network.HTTP.HTTP
 export project.Network.HTTP.HTTP_Method.HTTP_Method

diff --git a/distribution/lib/Standard/Base/0.0.0-dev/src/Network/HTTP.enso b/distribution/lib/Standard/Base/0.0.0-dev/src/Network/HTTP.enso
@@ -27,8 +27,6 @@ polyglot java import java.net.http.HttpRequest
 polyglot java import java.net.http.HttpResponse
 polyglot java import java.net.InetSocketAddress
 polyglot java import java.net.ProxySelector
-polyglot java import java.net.URI
-polyglot java import java.time.Duration as Java_Duration
 polyglot java import org.enso.base.Http_Utils
 
 type HTTP

diff --git a/distribution/lib/Standard/Base/0.0.0-dev/src/Network/HTTP/Request.enso b/distribution/lib/Standard/Base/0.0.0-dev/src/Network/HTTP/Request.enso
@@ -2,7 +2,7 @@ import project.Any.Any
 import project.Data.Pair.Pair
 import project.Data.Text.Text
 import project.Data.Vector.Vector
-import project.Network.Extensions
+from project.Network.Extensions import all
 import project.Network.HTTP.Form.Form
 import project.Network.HTTP.Header.Header
 import project.Network.HTTP.HTTP_Method.HTTP_Method

diff --git a/distribution/lib/Standard/Base/0.0.0-dev/src/Network/HTTP/Response.enso b/distribution/lib/Standard/Base/0.0.0-dev/src/Network/HTTP/Response.enso
@@ -3,7 +3,7 @@ import project.Data.Boolean.Boolean
 import project.Data.Json.JS_Object
 import project.Data.Numbers.Number
 import project.Data.Text.Encoding.Encoding
-import project.Data.Text.Extensions
+from project.Data.Text.Extensions import all
 import project.Data.Text.Text
 import project.Data.Vector.Vector
 import project.Error.Error

diff --git a/distribution/lib/Standard/Base/0.0.0-dev/src/Network/HTTP/Response_Body.enso b/distribution/lib/Standard/Base/0.0.0-dev/src/Network/HTTP/Response_Body.enso
@@ -3,7 +3,7 @@ import project.Data.Json.Json
 import project.Data.Json.JS_Object
 import project.Data.Numbers.Number
 import project.Data.Text.Encoding.Encoding
-import project.Data.Text.Extensions
+from project.Data.Text.Extensions import all
 import project.Data.Text.Text
 import project.Data.Vector.Vector
 import project.Nothing.Nothing

diff --git a/distribution/lib/Standard/Base/0.0.0-dev/src/Random.enso b/distribution/lib/Standard/Base/0.0.0-dev/src/Random.enso
@@ -5,7 +5,6 @@ import project.Data.Numbers.Decimal
 import project.Data.Text.Text
 import project.Data.Vector.Vector
 import project.Data.Json.JS_Object
-import project.Data.Text.Text
 import project.Error.Error
 import project.Errors.Illegal_Argument.Illegal_Argument
 import project.System

diff --git a/distribution/lib/Standard/Base/0.0.0-dev/src/Runtime.enso b/distribution/lib/Standard/Base/0.0.0-dev/src/Runtime.enso
@@ -2,7 +2,7 @@ import project.Any.Any
 import project.Data.Array.Array
 import project.Data.Boolean.Boolean
 import project.Data.Text.Case.Case
-import project.Data.Text.Extensions
+from project.Data.Text.Extensions import all
 import project.Data.Text.Text
 import project.Data.Vector.Vector
 import project.Errors.Common.Forbidden_Operation

diff --git a/distribution/lib/Standard/Base/0.0.0-dev/src/System/File.enso b/distribution/lib/Standard/Base/0.0.0-dev/src/System/File.enso
@@ -1,4 +1,3 @@
-from Standard.Base import all
 import project.Any.Any
 import project.Data.Array.Array
 import project.Data.Index_Sub_Range.Index_Sub_Range
@@ -24,6 +23,7 @@ import project.Runtime.Context
 import project.Runtime.Managed_Resource.Managed_Resource
 import project.System.File.File_Access.File_Access
 import project.System.File.File_Permissions.File_Permissions
+import project.Warning.Warning
 
 from project.Data.Boolean import Boolean, True, False
 from project.System.File_Format import Auto_Detect, File_Format

diff --git a/distribution/lib/Standard/Base/0.0.0-dev/src/System/File/Write_Extensions.enso b/distribution/lib/Standard/Base/0.0.0-dev/src/System/File/Write_Extensions.enso
@@ -1,6 +1,6 @@
 import project.Data.Text.Text
 import project.Data.Text.Encoding.Encoding
-import project.Data.Text.Extensions
+from project.Data.Text.Extensions import all
 import project.Data.Vector.Vector
 import project.Error.Error
 import project.Errors.Common.Unsupported_Argument_Types

diff --git a/distribution/lib/Standard/Base/0.0.0-dev/src/System/File_Format.enso b/distribution/lib/Standard/Base/0.0.0-dev/src/System/File_Format.enso
@@ -1,7 +1,7 @@
 import project.Any.Any
 import project.Data.Json.Json
 import project.Data.Text.Encoding.Encoding
-import project.Data.Text.Extensions
+from project.Data.Text.Extensions import all
 import project.Data.Text.Text
 import project.Data.Vector.Vector
 import project.Error.Error