Skip to content

Commit

Permalink
rename tooltip message, sort sorting for truncated data and re introd…
Browse files Browse the repository at this point in the history
…uce the row label (#10533)

closes #10530

this renames the tooltip from using 'node' to 'component,

<img width="341" alt="image" src="https://github.com/enso-org/enso/assets/170310417/1ee35556-a982-47aa-99ac-544108b11afe">

![row-label](https://github.com/enso-org/enso/assets/170310417/d81482d9-df49-45da-b447-571a8e9171ea)
  • Loading branch information
marthasharkey authored Jul 11, 2024
1 parent 017cf4f commit 4c0fbf0
Showing 1 changed file with 4 additions and 5 deletions.
9 changes: 4 additions & 5 deletions app/gui2/src/components/visualizations/TableVisualization.vue
Original file line number Diff line number Diff line change
Expand Up @@ -330,7 +330,7 @@ function toField(name: string, valueType?: ValueType | null | undefined): ColDef
const menu = `<span ref="eMenu" class="ag-header-icon ag-header-cell-menu-button"> </span>`
const sort = `
<span ref="eFilter" class="ag-header-icon ag-header-label-icon ag-filter-icon" aria-hidden="true"></span>
<span ref="eSortOrder" class="ag-header-icon ag-sort-order" aria-hidden="true">1</span>
<span ref="eSortOrder" class="ag-header-icon ag-sort-order" aria-hidden="true"></span>
<span ref="eSortAsc" class="ag-header-icon ag-sort-ascending-icon" aria-hidden="true"></span>
<span ref="eSortDesc" class="ag-header-icon ag-sort-descending-icon" aria-hidden="true"></span>
<span ref="eSortNone" class="ag-header-icon ag-sort-none-icon" aria-hidden="true"></span>
Expand All @@ -343,7 +343,6 @@ function toField(name: string, valueType?: ValueType | null | undefined): ColDef
field: name,
headerComponentParams: {
template,
enableSorting: true,
setAriaSort: () => {},
},
headerTooltip: displayValue ? displayValue : '',
Expand Down Expand Up @@ -406,7 +405,7 @@ function toLinkField(fieldName: string): ColDef {
field: fieldName,
onCellDoubleClicked: (params) => createNode(params),
tooltipValueGetter: () => {
return `Double click to view this ${newNodeSelectorValues.value.tooltipValue} in a separate node`
return `Double click to view this ${newNodeSelectorValues.value.tooltipValue} in a separate component`
},
cellRenderer: (params: any) => `<a href='#'> ${params.value} </a>`,
}
Expand Down Expand Up @@ -657,15 +656,15 @@ onUnmounted(() => {
v-text="limit"
></option>
</select>
<div v-if="showRowCount">
<template v-if="showRowCount">
<span
v-if="isRowCountSelectorVisible && isTruncated"
v-text="` of ${rowCount} rows (Sorting/Filtering disabled).`"
></span>
<span v-else-if="isRowCountSelectorVisible" v-text="' rows.'"></span>
<span v-else-if="rowCount === 1" v-text="'1 row.'"></span>
<span v-else v-text="`${rowCount} rows.`"></span>
</div>
</template>
</div>
<div ref="tableNode" class="scrollable ag-theme-alpine"></div>
</div>
Expand Down

0 comments on commit 4c0fbf0

Please sign in to comment.